Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: use string values for TargetPurpose enum #7257

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Firestore: use string values for TargetPurpose enum #7257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae3e211
Firestore: target_data.ts: use string values for TargetPurpose enum, …
dconeybe Apr 24, 2023
5e43cd8
Merge remote-tracking branch 'origin/master' into TargetPurposeString…
dconeybe Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/firestore/src/local/target_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,22 @@ import { ByteString } from '../util/byte_string';
/** An enumeration of the different purposes we have for targets. */
export const enum TargetPurpose {
/** A regular, normal query target. */
Listen,
Listen = 'TargetPurposeListen',

/**
* The query target was used to refill a query after an existence filter
* mismatch.
*/
ExistenceFilterMismatch,
ExistenceFilterMismatch = 'TargetPurposeExistenceFilterMismatch',

/**
* The query target was used if the query is the result of a false positive in
* the bloom filter.
*/
ExistenceFilterMismatchBloom,
ExistenceFilterMismatchBloom = 'TargetPurposeExistenceFilterMismatchBloom',

/** The query target was used to resolve a limbo document. */
LimboResolution
LimboResolution = 'TargetPurposeLimboResolution'
}

/**
Expand Down