Allow port numbers in authdomain #7277

bhparijat · 2023-05-04T20:50:48Z

Testing

Used demo app to test changes. The authdomain was set to localhost:8080 and I saw the redirect hitting URL
https://localhost:8080/__/auth/handler?apiKey=<API_KEY>&appName=%5BDEFAULT%5D&authType=signInViaRedirect&redirectUrl=http%3A%2F%2Flocalhost%3A5000%2F&v=9.8.1&providerId=google.com&scopes=profile

Fixes: #7233

changeset-bot · 2023-05-04T20:50:52Z

🦋 Changeset detected

Latest commit: d8b4450

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/auth	Patch
@firebase/auth-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-05-04T21:12:17Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`92e2279`)	Merge (`68ce67d`)	Diff
browser	171 kB	170 kB	-119 B (-0.1%)
cordova	198 kB	198 kB	-119 B (-0.1%)
esm5	223 kB	223 kB	-119 B (-0.1%)
main	168 kB	167 kB	-119 B (-0.1%)
module	171 kB	170 kB	-119 B (-0.1%)
react-native	183 kB	183 kB	-119 B (-0.1%)

@firebase/auth/cordova
Type Base (92e2279) Merge (68ce67d) Diff
browser 198 kB 198 kB -119 B (-0.1%)
module 198 kB 198 kB -119 B (-0.1%)
@firebase/auth/internal
Type Base (92e2279) Merge (68ce67d) Diff
browser 181 kB 181 kB -119 B (-0.1%)
esm5 237 kB 237 kB -119 B (-0.1%)
main 204 kB 204 kB -121 B (-0.1%)
module 181 kB 181 kB -119 B (-0.1%)
@firebase/auth/react-native
Type Base (92e2279) Merge (68ce67d) Diff
browser 183 kB 183 kB -119 B (-0.1%)
module 183 kB 183 kB -119 B (-0.1%)

`bundle`

Type	Base (`92e2279`)	Merge (`68ce67d`)	Diff
auth (Anonymous)	71.2 kB	71.1 kB	-85 B (-0.1%)
auth (EmailAndPassword)	76.2 kB	76.1 kB	-85 B (-0.1%)
auth (GoogleFBTwitterGitHubPopup)	97.4 kB	97.3 kB	-85 B (-0.1%)
auth (GooglePopup)	94.7 kB	94.6 kB	-85 B (-0.1%)
auth (GoogleRedirect)	94.9 kB	94.8 kB	-85 B (-0.1%)
auth (Phone)	81.1 kB	81.0 kB	-85 B (-0.1%)

`firebase`

Type	Base (`92e2279`)	Merge (`68ce67d`)	Diff
firebase-auth-compat.js	132 kB	132 kB	-78 B (-0.1%)
firebase-auth-cordova.js	147 kB	147 kB	-72 B (-0.0%)
firebase-auth-react-native.js	160 kB	160 kB	-72 B (-0.0%)
firebase-auth.js	127 kB	127 kB	-71 B (-0.1%)
firebase-compat.js	773 kB	773 kB	-79 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/8AghSYAFkw.html

google-oss-bot · 2023-05-04T21:27:15Z

Size Analysis Report ¹

Affected Products

@firebase/auth
- ActionCodeOperation
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.4 kB 35.3 kB -84 B (-0.2%)
  size-with-ext-deps 56.2 kB 56.1 kB -85 B (-0.2%)
- ActionCodeURL
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.2 kB 36.1 kB -84 B (-0.2%)
  size-with-ext-deps 57.2 kB 57.2 kB -85 B (-0.1%)
- AuthCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.4 kB 35.3 kB -84 B (-0.2%)
  size-with-ext-deps 56.2 kB 56.1 kB -85 B (-0.2%)
- AuthErrorCodes
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.2 kB 40.1 kB -84 B (-0.2%)
  size-with-ext-deps 61.0 kB 60.9 kB -85 B (-0.1%)
- EmailAuthCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 38.0 kB 37.9 kB -84 B (-0.2%)
  size-with-ext-deps 58.8 kB 58.7 kB -85 B (-0.1%)
- EmailAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 39.5 kB 39.4 kB -84 B (-0.2%)
  size-with-ext-deps 60.5 kB 60.4 kB -85 B (-0.1%)
- FacebookAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.2 kB 40.1 kB -84 B (-0.2%)
  size-with-ext-deps 61.0 kB 60.9 kB -85 B (-0.1%)
- FactorId
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.9 kB -85 B (-0.2%)
- GithubAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.2 kB 40.1 kB -84 B (-0.2%)
  size-with-ext-deps 61.0 kB 60.9 kB -85 B (-0.1%)
- GoogleAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.2 kB 40.1 kB -84 B (-0.2%)
  size-with-ext-deps 61.0 kB 60.9 kB -85 B (-0.1%)
- OAuthCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 37.3 kB 37.2 kB -84 B (-0.2%)
  size-with-ext-deps 58.1 kB 58.0 kB -85 B (-0.1%)
- OAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 41.1 kB 41.0 kB -84 B (-0.2%)
  size-with-ext-deps 61.9 kB 61.8 kB -85 B (-0.1%)
- OperationType
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- PhoneAuthCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 37.3 kB 37.2 kB -84 B (-0.2%)
  size-with-ext-deps 58.1 kB 58.0 kB -85 B (-0.1%)
- PhoneAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 39.0 kB 38.9 kB -84 B (-0.2%)
  size-with-ext-deps 59.8 kB 59.7 kB -85 B (-0.1%)
- PhoneMultiFactorGenerator
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.0 kB 35.9 kB -84 B (-0.2%)
  size-with-ext-deps 56.8 kB 56.7 kB -85 B (-0.1%)
- ProviderId
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.3 kB 35.2 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 56.0 kB -85 B (-0.2%)
- RecaptchaVerifier
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 41.4 kB 41.3 kB -84 B (-0.2%)
  size-with-ext-deps 62.1 kB 62.1 kB -85 B (-0.1%)
- SAMLAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 41.5 kB 41.4 kB -84 B (-0.2%)
  size-with-ext-deps 62.2 kB 62.2 kB -85 B (-0.1%)
- SignInMethod
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.3 kB 35.2 kB -84 B (-0.2%)
  size-with-ext-deps 56.1 kB 56.0 kB -85 B (-0.2%)
- TotpMultiFactorGenerator
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 37.6 kB 37.5 kB -84 B (-0.2%)
  size-with-ext-deps 58.4 kB 58.3 kB -85 B (-0.1%)
- TotpSecret
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.1 kB 36.0 kB -84 B (-0.2%)
  size-with-ext-deps 56.9 kB 56.8 kB -85 B (-0.1%)
- TwitterAuthProvider
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.2 kB 40.1 kB -84 B (-0.2%)
  size-with-ext-deps 61.0 kB 60.9 kB -85 B (-0.1%)
- applyActionCode
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.3 kB 35.2 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- beforeAuthStateChanged
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- browserLocalPersistence
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 38.6 kB 38.5 kB -84 B (-0.2%)
  size-with-ext-deps 59.4 kB 59.3 kB -85 B (-0.1%)
- browserPopupRedirectResolver
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 59.2 kB 59.1 kB -84 B (-0.1%)
  size-with-ext-deps 80.2 kB 80.1 kB -85 B (-0.1%)
- browserSessionPersistence
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 38.6 kB 38.5 kB -84 B (-0.2%)
  size-with-ext-deps 59.4 kB 59.3 kB -85 B (-0.1%)
- checkActionCode
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.4 kB 36.3 kB -84 B (-0.2%)
  size-with-ext-deps 57.2 kB 57.1 kB -85 B (-0.1%)
- confirmPasswordReset
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.3 kB 35.2 kB -84 B (-0.2%)
  size-with-ext-deps 56.1 kB 56.0 kB -85 B (-0.2%)
- connectAuthEmulator
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.9 kB 36.8 kB -84 B (-0.2%)
  size-with-ext-deps 57.7 kB 57.6 kB -85 B (-0.1%)
- createUserWithEmailAndPassword
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 37.0 kB 36.9 kB -84 B (-0.2%)
  size-with-ext-deps 57.8 kB 57.7 kB -85 B (-0.1%)
- debugErrorMap
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 47.1 kB 47.0 kB -84 B (-0.2%)
  size-with-ext-deps 67.9 kB 67.8 kB -85 B (-0.1%)
- deleteUser
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.9 kB -85 B (-0.2%)
- fetchSignInMethodsForEmail
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.5 kB 35.4 kB -84 B (-0.2%)
  size-with-ext-deps 56.3 kB 56.2 kB -85 B (-0.2%)
- getAdditionalUserInfo
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.5 kB 36.4 kB -84 B (-0.2%)
  size-with-ext-deps 57.3 kB 57.2 kB -85 B (-0.1%)
- getAuth
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 69.3 kB 69.2 kB -84 B (-0.1%)
  size-with-ext-deps 96.7 kB 96.7 kB -85 B (-0.1%)
- getIdToken
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- getIdTokenResult
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.1 kB 35.0 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.8 kB -85 B (-0.2%)
- getMultiFactorResolver
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 38.0 kB 38.0 kB -84 B (-0.2%)
  size-with-ext-deps 58.8 kB 58.7 kB -85 B (-0.1%)
- getRedirectResult
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 42.7 kB 42.6 kB -84 B (-0.2%)
  size-with-ext-deps 63.5 kB 63.4 kB -85 B (-0.1%)
- inMemoryPersistence
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.1 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.8 kB -85 B (-0.2%)
- indexedDBLocalPersistence
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 42.6 kB 42.5 kB -84 B (-0.2%)
  size-with-ext-deps 63.3 kB 63.3 kB -85 B (-0.1%)
- initializeAuth
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.4 kB 35.3 kB -84 B (-0.2%)
  size-with-ext-deps 56.7 kB 56.6 kB -85 B (-0.2%)
- initializeRecaptchaConfig
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- isSignInWithEmailLink
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.3 kB 36.3 kB -84 B (-0.2%)
  size-with-ext-deps 57.4 kB 57.3 kB -85 B (-0.1%)
- linkWithCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.2 kB 36.1 kB -84 B (-0.2%)
  size-with-ext-deps 57.0 kB 56.9 kB -85 B (-0.1%)
- linkWithPhoneNumber
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 39.7 kB 39.6 kB -84 B (-0.2%)
  size-with-ext-deps 60.5 kB 60.4 kB -85 B (-0.1%)
- linkWithPopup
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 46.3 kB 46.2 kB -84 B (-0.2%)
  size-with-ext-deps 67.1 kB 67.0 kB -85 B (-0.1%)
- linkWithRedirect
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 41.5 kB 41.4 kB -84 B (-0.2%)
  size-with-ext-deps 62.3 kB 62.2 kB -85 B (-0.1%)
- multiFactor
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 37.4 kB 37.3 kB -84 B (-0.2%)
  size-with-ext-deps 58.1 kB 58.1 kB -85 B (-0.1%)
- onAuthStateChanged
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- onIdTokenChanged
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- parseActionCodeURL
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.3 kB 36.2 kB -84 B (-0.2%)
  size-with-ext-deps 57.3 kB 57.2 kB -85 B (-0.1%)
- prodErrorMap
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.1 kB 35.0 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.8 kB -85 B (-0.2%)
- reauthenticateWithCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.7 kB 36.7 kB -84 B (-0.2%)
  size-with-ext-deps 57.5 kB 57.4 kB -85 B (-0.1%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.3 kB 40.2 kB -84 B (-0.2%)
  size-with-ext-deps 61.1 kB 61.0 kB -85 B (-0.1%)
- reauthenticateWithPopup
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 46.3 kB 46.2 kB -84 B (-0.2%)
  size-with-ext-deps 67.1 kB 67.0 kB -85 B (-0.1%)
- reauthenticateWithRedirect
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 41.2 kB 41.2 kB -84 B (-0.2%)
  size-with-ext-deps 62.0 kB 61.9 kB -85 B (-0.1%)
- reload
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.1 kB 35.0 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.8 kB -85 B (-0.2%)
- sendEmailVerification
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.1 kB 36.0 kB -84 B (-0.2%)
  size-with-ext-deps 56.9 kB 56.8 kB -85 B (-0.1%)
- sendPasswordResetEmail
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.8 kB 36.8 kB -84 B (-0.2%)
  size-with-ext-deps 57.6 kB 57.5 kB -85 B (-0.1%)
- sendSignInLinkToEmail
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.9 kB 36.8 kB -84 B (-0.2%)
  size-with-ext-deps 57.7 kB 57.6 kB -85 B (-0.1%)
- setPersistence
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- signInAnonymously
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.3 kB 36.2 kB -84 B (-0.2%)
  size-with-ext-deps 57.1 kB 57.0 kB -85 B (-0.1%)
- signInWithCredential
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.5 kB 36.4 kB -84 B (-0.2%)
  size-with-ext-deps 57.3 kB 57.2 kB -85 B (-0.1%)
- signInWithCustomToken
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.2 kB 36.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.9 kB 56.9 kB -85 B (-0.1%)
- signInWithEmailAndPassword
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.9 kB 40.8 kB -84 B (-0.2%)
  size-with-ext-deps 62.0 kB 61.9 kB -85 B (-0.1%)
- signInWithEmailLink
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 41.1 kB 41.0 kB -84 B (-0.2%)
  size-with-ext-deps 62.2 kB 62.1 kB -85 B (-0.1%)
- signInWithPhoneNumber
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.1 kB 40.0 kB -84 B (-0.2%)
  size-with-ext-deps 60.9 kB 60.8 kB -85 B (-0.1%)
- signInWithPopup
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 46.2 kB 46.2 kB -84 B (-0.2%)
  size-with-ext-deps 67.0 kB 67.0 kB -85 B (-0.1%)
- signInWithRedirect
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 40.9 kB 40.9 kB -84 B (-0.2%)
  size-with-ext-deps 61.7 kB 61.6 kB -85 B (-0.1%)
- signOut
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 55.9 kB 55.9 kB -85 B (-0.2%)
- unlink
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.7 kB 35.7 kB -84 B (-0.2%)
  size-with-ext-deps 56.5 kB 56.4 kB -85 B (-0.2%)
- updateCurrentUser
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- updateEmail
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.5 kB 35.4 kB -84 B (-0.2%)
  size-with-ext-deps 56.2 kB 56.1 kB -85 B (-0.2%)
- updatePassword
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.5 kB 35.4 kB -84 B (-0.2%)
  size-with-ext-deps 56.2 kB 56.1 kB -85 B (-0.2%)
- updatePhoneNumber
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.9 kB 35.8 kB -84 B (-0.2%)
  size-with-ext-deps 56.7 kB 56.6 kB -85 B (-0.1%)
- updateProfile
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.6 kB 35.6 kB -84 B (-0.2%)
  size-with-ext-deps 56.4 kB 56.3 kB -85 B (-0.2%)
- useDeviceLanguage
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 35.2 kB 35.1 kB -84 B (-0.2%)
  size-with-ext-deps 56.0 kB 55.9 kB -85 B (-0.2%)
- verifyBeforeUpdateEmail
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.1 kB 36.0 kB -84 B (-0.2%)
  size-with-ext-deps 56.9 kB 56.8 kB -85 B (-0.1%)
- verifyPasswordResetCode
  Size
  Type Base (92e2279) Merge (ad4c44d) Diff
  size 36.4 kB 36.4 kB -84 B (-0.2%)
  size-with-ext-deps 57.2 kB 57.1 kB -85 B (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/zGQiB7Ndbk.html

renkelvin · 2023-05-04T22:41:15Z

Test Modified Packages / Test Packages With Changed Files in Firefox (pull_request) seems timeout. Please try run it again.
Otherwise LGTM.

.changeset/small-chairs-explain.md

packages/auth/src/core/auth/register.test.ts

prameshj

Thanks!

bhparijat requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners May 4, 2023 20:50

bhparijat assigned prameshj and renkelvin May 4, 2023

removed assertion to check for port numbers in authdomain

d3ebdd4

bhparijat force-pushed the fix-port-authomain branch from b59c585 to e0c00a9 Compare May 4, 2023 21:05

bhparijat requested review from a team as code owners May 4, 2023 21:05

renkelvin approved these changes May 4, 2023

View reviewed changes

renkelvin reviewed May 4, 2023

View reviewed changes

.changeset/small-chairs-explain.md Outdated Show resolved Hide resolved

bhparijat force-pushed the fix-port-authomain branch from e53f841 to 43c8261 Compare May 5, 2023 03:39

prameshj reviewed May 5, 2023

View reviewed changes

packages/auth/src/core/auth/register.test.ts Outdated Show resolved Hide resolved

prameshj reviewed May 5, 2023

View reviewed changes

packages/auth/src/core/auth/register.test.ts Outdated Show resolved Hide resolved

bhparijat force-pushed the fix-port-authomain branch from 97fc169 to 03e6314 Compare May 5, 2023 20:15

adding changeset

d8b4450

bhparijat force-pushed the fix-port-authomain branch from 03e6314 to d8b4450 Compare May 5, 2023 20:16

bhparijat requested a review from prameshj May 5, 2023 20:23

prameshj approved these changes May 5, 2023

View reviewed changes

bhparijat assigned lisajian May 5, 2023

hsubox76 approved these changes May 5, 2023

View reviewed changes

bhparijat merged commit afdccd5 into master May 5, 2023

bhparijat deleted the fix-port-authomain branch May 5, 2023 21:40

google-oss-bot mentioned this pull request May 11, 2023

Version Packages #7290

Merged

falk-stefan mentioned this pull request May 18, 2023

Upgrade @firebase/auth to version 0.23.2 angular/angularfire#3357

Open

firebase locked and limited conversation to collaborators Jun 5, 2023

Allow port numbers in authdomain #7277

Allow port numbers in authdomain #7277

Conversation

bhparijat commented May 4, 2023 • edited Loading

Testing

changeset-bot bot commented May 4, 2023 • edited Loading

🦋 Changeset detected

google-oss-bot commented May 4, 2023 • edited Loading

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

google-oss-bot commented May 4, 2023 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TotpMultiFactorGenerator

TotpSecret

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

initializeRecaptchaConfig

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

prodErrorMap

reauthenticateWithCredential

reauthenticateWithPhoneNumber

reauthenticateWithPopup

reauthenticateWithRedirect

bhparijat commented May 4, 2023 •

edited

Loading

changeset-bot bot commented May 4, 2023 •

edited

Loading

google-oss-bot commented May 4, 2023 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

google-oss-bot commented May 4, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TotpMultiFactorGenerator`

`TotpSecret`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`initializeRecaptchaConfig`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`