Add Type Checking to ParseToken Map #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb2d38f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (1ff891c) and merge commit (975c3b3).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (1ff891c) and merge commit (975c3b3).Test Logs |
Evanition
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc,
a team,
dwyfrequency and
hsubox76
as code owners
renkelvin
reviewed
Jun 8, 2023
prameshj
approved these changes
Jun 8, 2023
renkelvin
approved these changes
Jun 9, 2023
hsubox76
requested changes
Jun 12, 2023
hsubox76
approved these changes
Jul 5, 2023
Evanition
force-pushed
the
DewayneTestBranch
branch
from
dd974ed to
fb2d38f
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type checking to the ParsedToken map to create a more type safe interface, also added some unit testing to verify it was working as expected