Implement revokeAccessToken public api #7541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NhienLam
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc,
a team,
dwyfrequency and
hsubox76
as code owners
|
NhienLam
requested review from
bhparijat
and removed request for
a team,
sam-gc,
dwyfrequency,
hsubox76 and
lisajian
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (248,751 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
NhienLam
requested review from
egilmorez,
markarndt and
kevinthecheung
as code owners
renkelvin
reviewed
Aug 10, 2023
renkelvin
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement revokeAccessToken public api.
Note:
-Did not add tests to auth_impl.test.ts because backend doesn’t return anything for revokeToken api and we cannot verify if apple oauth access token is revoked in auth_impl.test.ts. Please let me know if I’m wrong or there are ways to test
auth_impl#revokeAccessToken.-Tested with demo app and was able to revoke apple oauth access token. However, wasn't able to test in multi-tenancy environment because firebase test project doesn't support multi-tenancy and I don't have a personal project that has Apply sign in provider set up.
TODO: Write integration tests if we can retrieve the apple oauth access token in the testing environment.