Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using authTokenSyncURL if the string begins with a double slash #8060

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Mar 8, 2024

Additional fix to #8056 to prevent the string beginning with a double slash.

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: af52435

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 requested a review from DellaBitta March 8, 2024 23:00
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (2b22838)Merge (a00c3e9)Diff
    browser177 kB177 kB+4 B (+0.0%)
    esm5231 kB231 kB+4 B (+0.0%)
    module177 kB177 kB+4 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (2b22838)Merge (a00c3e9)Diff
    browser188 kB188 kB+4 B (+0.0%)
    esm5244 kB244 kB+4 B (+0.0%)
    module188 kB188 kB+4 B (+0.0%)
  • bundle

    TypeBase (2b22838)Merge (a00c3e9)Diff
    auth (GoogleFBTwitterGitHubPopup)101 kB101 kB+4 B (+0.0%)
  • firebase

    TypeBase (2b22838)Merge (a00c3e9)Diff
    firebase-auth.js147 kB147 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Bo01riETTg.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • getAuth

      Size

      TypeBase (2b22838)Merge (a00c3e9)Diff
      size72.4 kB72.4 kB+4 B (+0.0%)
      size-with-ext-deps100 kB100 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IICpb7QsUY.html

@hsubox76 hsubox76 merged commit 6d487d7 into master Mar 11, 2024
44 checks passed
@hsubox76 hsubox76 deleted the ch-defaults-fix-2 branch March 11, 2024 18:38
@google-oss-bot google-oss-bot mentioned this pull request Mar 12, 2024
@firebase firebase locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants