Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary rtdb changes #8350

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Removed unnecessary rtdb changes #8350

merged 2 commits into from
Jul 3, 2024

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Jul 3, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 680a25f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maneesht maneesht marked this pull request as ready for review July 3, 2024 18:19
@maneesht maneesht requested review from a team and aashishpatil-g as code owners July 3, 2024 18:19
@maneesht maneesht merged commit 4254b10 into dataconnect Jul 3, 2024
16 of 20 checks passed
@maneesht maneesht deleted the mtewani/remove-database-changes branch July 3, 2024 18:19
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 3, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (5eedc9a)Merge (154a028)Diff
    browser249 kB249 kB-23 B (-0.0%)
    esm5277 kB277 kB-24 B (-0.0%)
    main282 kB282 kB-24 B (-0.0%)
    module249 kB249 kB-23 B (-0.0%)

  • @firebase/database-compat/standalone

    TypeBase (5eedc9a)Merge (154a028)Diff
    main372 kB372 kB-24 B (-0.0%)

  • bundle

    TypeBase (5eedc9a)Merge (154a028)Diff
    database (Filtering data)148 kB148 kB-23 B (-0.0%)

  • firebase

    TypeBase (5eedc9a)Merge (154a028)Diff
    firebase-compat.js786 kB786 kB-23 B (-0.0%)
    firebase-database-compat.js166 kB166 kB-23 B (-0.0%)
    firebase-database.js186 kB186 kB-23 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UgoI0ae1h8.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 3, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/database

    • limitToLast

      Size

      TypeBase (5eedc9a)Merge (154a028)Diff
      size116 kB116 kB-23 B (-0.0%)
      size-with-ext-deps138 kB138 kB-23 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ONYMw05aJK.html

@firebase firebase locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maneesht @google-oss-bot