Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove indentation in Vertex AI API Not Enabled Error #8587

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

dlarocque
Copy link
Contributor

If we use a multi-line template string for the error message, the indentation will be preserved. We should instead add multiple single-line template strings.

@dlarocque dlarocque requested a review from hsubox76 October 22, 2024 17:51
@dlarocque dlarocque requested a review from a team as a code owner October 22, 2024 17:51
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 419d83b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 22, 2024

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (0f5a9aa)Merge (1e767ec)Diff
    browser28.7 kB28.7 kB-48 B (-0.2%)
    main29.6 kB29.5 kB-48 B (-0.2%)
    module28.7 kB28.7 kB-48 B (-0.2%)
  • firebase

    TypeBase (0f5a9aa)Merge (1e767ec)Diff
    firebase-vertexai.js22.2 kB22.1 kB-66 B (-0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SXxNIhLGJC.html

@dlarocque dlarocque requested review from a team as code owners October 22, 2024 18:20
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 22, 2024

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ChatSession

      Size

      TypeBase (0f5a9aa)Merge (1e767ec)Diff
      size14.6 kB14.5 kB-48 B (-0.3%)
      size-with-ext-deps33.1 kB33.1 kB-48 B (-0.1%)
    • GenerativeModel

      Size

      TypeBase (0f5a9aa)Merge (1e767ec)Diff
      size17.1 kB17.0 kB-48 B (-0.3%)
      size-with-ext-deps35.6 kB35.6 kB-48 B (-0.1%)
    • getGenerativeModel

      Size

      TypeBase (0f5a9aa)Merge (1e767ec)Diff
      size17.2 kB17.2 kB-48 B (-0.3%)
      size-with-ext-deps35.8 kB35.7 kB-48 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b37rD33Y83.html

@dlarocque dlarocque merged commit 1f1ba3f into main Oct 23, 2024
38 of 39 checks passed
@dlarocque dlarocque deleted the dl/vertex-error-fmt branch October 23, 2024 16:59
@google-oss-bot google-oss-bot mentioned this pull request Nov 12, 2024
@firebase firebase locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants