-
Notifications
You must be signed in to change notification settings - Fork 939
Fireperf web vitals #8644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fireperf web vitals #8644
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e1cb176
Add support for capturing web vitals metrics in Firebase performance …
bryanatkinson 7d4d75c
Add unit tests for oob_resource_service changes to include web vitals.
bryanatkinson 7a39d7d
Update perf_logger tests.
bryanatkinson 7ad639a
Remove .only in test.
bryanatkinson 61295c5
Update transport_service test.
bryanatkinson 51104e8
Remove flush from tests due to globals conflict.
bryanatkinson 0158070
Run format
bryanatkinson 66ffeb0
Remove FID wait timeout on OOB trace send. This gets sent at first un…
bryanatkinson 19cf2c4
Queue OOB trace instead of sending right away. The web vitals library…
bryanatkinson b033187
Update tests
bryanatkinson 841fd9e
Update tests
bryanatkinson 3440ead
Run format
bryanatkinson bbbfc06
Add changeset
bryanatkinson bc86a9e
Update changeset to include firebase
bryanatkinson 140f3c3
Fix package.json
bryanatkinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@firebase/performance': minor | ||
'firebase': minor | ||
--- | ||
|
||
Collect web vital metrics (INP,CLS,LCP) as part of page load event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/** | ||
* @license | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
export interface CoreVitalMetric { | ||
value: number; | ||
elementAttribution?: string; | ||
} | ||
|
||
export interface WebVitalMetrics { | ||
cls?: CoreVitalMetric; | ||
inp?: CoreVitalMetric; | ||
lcp?: CoreVitalMetric; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.