Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stephenarosaj/headerz #8749

Merged
merged 20 commits into from
Feb 5, 2025
Merged

Stephenarosaj/headerz #8749

merged 20 commits into from
Feb 5, 2025

Conversation

stephenarosaj
Copy link
Contributor

Add support for web framework tracking via custom headers

  • add CallerSdkTypeEnum enum to differentiate between frameworks
  • add _callerSdkType field and _setCallerSdkType() methods to DataConnect type, as well as DataConnectTransport types
  • remove _isUsingGen fields and functions (_isUsingGen = false is now represented by CallerSdkTypeEnum.Base, while _isUsingGen = true is represented by any value other than CallerSdkTypeEnum.Base)

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 99cced0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/data-connect Minor
firebase Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2025

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (82373b3)Merge (f03684e)Diff
    browser188 kB189 kB+469 B (+0.2%)
    cordova164 kB164 kB+469 B (+0.3%)
    main145 kB145 kB+469 B (+0.3%)
    module188 kB189 kB+469 B (+0.2%)
    react-native163 kB164 kB+469 B (+0.3%)
  • @firebase/auth-cordova

    TypeBase (82373b3)Merge (f03684e)Diff
    browser164 kB164 kB+469 B (+0.3%)
    module164 kB164 kB+469 B (+0.3%)
  • @firebase/auth-web-extension

    TypeBase (82373b3)Merge (f03684e)Diff
    browser140 kB140 kB+469 B (+0.3%)
    main157 kB158 kB+469 B (+0.3%)
    module140 kB140 kB+469 B (+0.3%)
  • @firebase/auth/internal

    TypeBase (82373b3)Merge (f03684e)Diff
    browser199 kB199 kB+469 B (+0.2%)
    main171 kB172 kB+471 B (+0.3%)
    module199 kB199 kB+469 B (+0.2%)
  • @firebase/data-connect

    TypeBase (82373b3)Merge (f03684e)Diff
    browser20.3 kB21.1 kB+835 B (+4.1%)
    main22.2 kB23.1 kB+933 B (+4.2%)
    module20.3 kB21.1 kB+835 B (+4.1%)
  • @firebase/database-compat/standalone

    TypeBase (82373b3)Merge (f03684e)Diff
    main366 kB366 kB+112 B (+0.0%)
  • @firebase/firestore

    TypeBase (82373b3)Merge (f03684e)Diff
    main589 kB589 kB+1 B (+0.0%)
  • bundle

    TypeBase (82373b3)Merge (f03684e)Diff
    auth (Anonymous)76.5 kB76.6 kB+147 B (+0.2%)
    auth (EmailAndPassword)86.6 kB86.8 kB+147 B (+0.2%)
    auth (GoogleFBTwitterGitHubPopup)103 kB104 kB+147 B (+0.1%)
    auth (GooglePopup)101 kB101 kB+147 B (+0.1%)
    auth (GoogleRedirect)101 kB101 kB+147 B (+0.1%)
    auth (Phone)94.0 kB94.2 kB+147 B (+0.2%)
    functions (call)34.8 kB34.8 kB-2 B (-0.0%)
  • firebase

    18 size changes

    TypeBase (82373b3)Merge (f03684e)Diff
    firebase-analytics-compat.js26.5 kB25.7 kB-795 B (-3.0%)
    firebase-app-check-compat.js23.2 kB22.6 kB-615 B (-2.6%)
    firebase-app-compat.js32.5 kB31.8 kB-700 B (-2.2%)
    firebase-auth-compat.js143 kB140 kB-3.36 kB (-2.3%)
    firebase-auth-cordova.js136 kB137 kB+444 B (+0.3%)
    firebase-auth-web-extension.js119 kB119 kB+444 B (+0.4%)
    firebase-auth.js155 kB155 kB+444 B (+0.3%)
    firebase-compat.js808 kB791 kB-17.0 kB (-2.1%)
    firebase-data-connect.js16.8 kB17.3 kB+554 B (+3.3%)
    firebase-database-compat.js166 kB164 kB-2.85 kB (-1.7%)
    firebase-firestore-compat.js345 kB338 kB-6.59 kB (-1.9%)
    firebase-functions-compat.js10.6 kB10.4 kB-254 B (-2.4%)
    firebase-installations-compat.js13.3 kB12.9 kB-384 B (-2.9%)
    firebase-messaging-compat.js38.7 kB37.0 kB-1.64 kB (-4.2%)
    firebase-performance-compat.js40.9 kB40.0 kB-868 B (-2.1%)
    firebase-remote-config-compat.js28.4 kB27.8 kB-564 B (-2.0%)
    firebase-storage-compat.js40.4 kB39.7 kB-690 B (-1.7%)
    firebase-vertexai.js24.0 kB24.2 kB+238 B (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j9bmnSofxN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2025

Size Analysis Report 1

This report is too large (70,082 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sWsXyQH1bO.html

Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Changset please?

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@stephenarosaj stephenarosaj marked this pull request as ready for review February 4, 2025 17:39
@stephenarosaj stephenarosaj requested review from a team as code owners February 4, 2025 17:39
'firebase': minor
---

Add custom request headers based on type of SDK calling Core SDK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will become release notes shortly. Could you rephrase this with our users in mind. Maybe something like:

Changed: Add custom request headers based on the type of SDK (TanStack, Angular, etc) that's invoking Data Connect requests. This will help us something something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - let me know what you think

@maneesht maneesht merged commit 313faf6 into main Feb 5, 2025
37 of 38 checks passed
@maneesht maneesht deleted the stephenarosaj/headerz branch February 5, 2025 17:59
This was referenced Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants