You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for the PRs for Auth and Firestore to be in place so all three may be merged at the same time.
Discussion
Update the connectDatabaseEmulator function to support its invocation more than once. If the Database instance is already in use, and connectDatabaseEmulator is invoked with the same configuration, then the invocation will now succeed instead of assert.
This unlocks support for web frameworks which may render the page numerous times with the same instances of RTDB. Before this PR customers needed to add extra code to guard against calling connectDatabaseEmulator in their SSR logic. Now we do that guarding logic on their behalf which should simplify our customer's apps.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge
Waiting for the PRs for Auth and Firestore to be in place so all three may be merged at the same time.
Discussion
Update the
connectDatabaseEmulator
function to support its invocation more than once. If the Database instance is already in use, andconnectDatabaseEmulator
is invoked with the same configuration, then the invocation will now succeed instead of assert.This unlocks support for web frameworks which may render the page numerous times with the same instances of RTDB. Before this PR customers needed to add extra code to guard against calling
connectDatabaseEmulator
in their SSR logic. Now we do that guarding logic on their behalf which should simplify our customer's apps.Fixes #6824.
Testing
CI, new tests added to integration tests.
API Changes
N/A