Fix: sort strings in UTF-8 encoded byte order with lazy encoding #8787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (572,783 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
milaGGL
changed the title
🦋 Changeset detectedLatest commit: 9653bdc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 14, 2025
Closed
dconeybe
reviewed
Feb 19, 2025
packages/firestore/src/util/misc.ts
Outdated
| } | ||
| } | ||
|
|
||
| // Compare lengths if all bytes are equal |
There was a problem hiding this comment.
Under what circumstances would all bytes be equal? If there were all equal, then wouldn't the "if" condition on line 85 have evaluated to false?
There was a problem hiding this comment.
yeah, IIUC since leftCodePoint !== rightCodePoint, comparison on line 101 should be non-zero for at least one iteration of the loop on line 96.
There was a problem hiding this comment.
nope, there are some cases where trailing surrogate gets falsy involved, and being misrepresented by bytes, which could lead to 2 equal byte array for 2 different code points. That's why the unit tests were failing in android sdk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings should be sorted in UTF-8 encoded byte order. Public document: https://cloud.google.com/firestore/docs/concepts/data-types#data_types
SDK sorts strings using built in comparator method, which sorts lexicographically, and leads to mismatch between server and sdk when special characters are present. This PR fixes the string order mismatches on document field, map key, and document key.
The previous fix added created a performance issue due to expensive UTF-8 encoding and reverted, #8774, #8778.
compareUtf8Stringsis updated to use lazy encoding instead.b/329441702