Skip to content

ci: Reorder reporters to prevent log message duplication #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Reorder reporters to prevent log message duplication #9040

wants to merge 1 commit into from

Conversation

MarkDuckworth
Copy link
Contributor

Reorder reporters in karma config to prevent log message duplication. Currently in CI actions that run Karma, all SDK logging is rendered twice (example). This fixes the issue.

See also: karma-runner/karma#2342 (comment)

@MarkDuckworth MarkDuckworth requested a review from a team as a code owner May 14, 2025 18:50
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 6289324

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@MarkDuckworth MarkDuckworth changed the title chore: Reorder reporters to prevent log message duplication ci: Reorder reporters to prevent log message duplication May 14, 2025
hsubox76
hsubox76 approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! This always bothered me but I was never able to find the source of it.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (799de59) and merge commit (25d7081).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/l181N8Hvri.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (799de59) and merge commit (25d7081).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vuENOQBb8v.html

@dlarocque
Copy link
Contributor

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkDuckworth @google-oss-bot @dlarocque @hsubox76