Enable concurrency-mode #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to react/experimental
yuchenshi
reviewed
Nov 25, 2020
| @@ -48,7 +48,7 @@ const RouterWithInit = () => { | |||
| ); | |||
| }; | |||
|
|
|||
| ReactDOM.render( | |||
| ReactDOM.unstable_createRoot(document.getElementById('root')!).render( | |||
There was a problem hiding this comment.
Please only enable blocking mode for now.
|
Heads up that ReactFire v3 will support apps that don't use concurrent mode, which means you can stick to a stable build of React. More detail on the API changes that enable this here: FirebaseExtended/reactfire#255 (comment) |
|
I guess we're already using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to react/experimental and bootstrap with unstable_createRoot