Emulators:exec should rethrow errors from emulator startup (#7976)

CHANGELOG.md

@@ -1,2 +1,3 @@
+- Fixes an issue where `emulators:exec` would return a 0 error code when emulators failed to start. (#7974)
 - Added `--import` and `emulators:export` support to the Data Connect emulator.
 - Added `firebase.json#emulators.dataconnect.dataDir`. When set, Data Connect data will be persisted to the configured directory between emulator runs.

src/emulator/commandUtils.ts

@@ -468,8 +468,9 @@ export async function emulatorExec(script: string, options: any): Promise<void>
     await sendVSCodeMessage({ message: VSCODE_MESSAGE.EMULATORS_STARTED });
     exitCode = await runScript(script, extraEnv);
     await controller.onExit(options);
-  } catch {
+  } catch (err: unknown) {
     await sendVSCodeMessage({ message: VSCODE_MESSAGE.EMULATORS_START_ERRORED });
+    throw err;
   } finally {
     await controller.cleanShutdown();
   }