-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot deploy symlinks #22
Comments
I tracked this down to an issue with isaacs/fstream but until that's fixed I've put some nicer error reporting in. v1.0.5 through npm has the fix. Thanks |
Stop using deprecated fs.existsSync method
This seems to be the case still. Is there any reason it has to be? |
This is the PR that fixes the issue: npm/fstream#16 (though a lot has changed since that PR first saw the light of day). The fix was identified 2 1/2 years ago, but the PR finally got assigned to someone a few months ago so it might actually be moving along |
When I had symlinks in my deploy target directory I got the error.
I replaced those symlinks with copied regular files, then the error resolved.
It is great that
firebase deploy
can handle symlinks kindly.The version of firebase-tools are installed via npm.
The text was updated successfully, but these errors were encountered: