Update to 8.4.3 failed and corrupted existing version

[voiceactivity]

**Platform:**OS X 10.9.5 (13F1911)

[REQUIRED] Test case:

Been prompted by the npm to update the firebase-tools: npm install -g firebase-tools

[REQUIRED] Steps to reproduce:

$sudo npm install -g firebase-tools

[REQUIRED] Expected behavior:

the firebase-tools should be updated to the newest v8.4.3

[REQUIRED] Actual behavior

npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
/usr/local/bin/firebase -> /usr/local/lib/node_modules/firebase-tools/lib/bin/firebase.js

protobufjs@6.9.0 postinstall /usr/local/lib/node_modules/firebase-tools/node_modules/protobufjs
node scripts/postinstall
storage-engine@3.0.7 postinstall /usr/local/lib/node_modules/firebase-tools/node_modules/storage-engine
node ./compatibility/detect.js

fs.js:115
throw err;
^

Error: EACCES: permission denied, open '/usr/local/lib/node_modules/firebase-tools/node_modules/storage-engine/lib/compatibility/index.js'
at Object.openSync (fs.js:439:3)
at Object.writeFileSync (fs.js:1190:35)
at /usr/local/lib/node_modules/firebase-tools/node_modules/storage-engine/lib/compatibility/detect.js:35:15
at Object. (/usr/local/lib/node_modules/firebase-tools/node_modules/storage-engine/lib/compatibility/detect.js:45:3)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3)
at Module.require (internal/modules/cjs/loader.js:637:17)
npm WARN ws@7.3.0 requires a peer of bufferutil@^4.0.1 but none is installed. You must install peer dependencies yourself.
npm WARN ws@7.3.0 requires a peer of utf-8-validate@^5.0.2 but none is installed. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! storage-engine@3.0.7 postinstall: node ./compatibility/detect.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the storage-engine@3.0.7 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

After this error I've lost my previous firebase-tools setup completely:
$ firebase --version
bash: firebase: command not found

This is the log file:
...
14621 timing action:postinstall Completed in 610ms
14622 verbose unlock done using /Users/pavel/.npm/_locks/staging-3a08f0df5026584d.lock for /usr/local/lib/node_modules/.staging
14623 timing stage:rollbackFailedOptional Completed in 2406ms
14624 timing stage:runTopLevelLifecycles Completed in 34054ms
14625 warn ws@7.3.0 requires a peer of bufferutil@^4.0.1 but none is installed. You must install peer dependencies yourself.
14626 warn ws@7.3.0 requires a peer of utf-8-validate@^5.0.2 but none is installed. You must install peer dependencies yourself.
14627 verbose stack Error: storage-engine@3.0.7 postinstall: node ./compatibility/detect.js
14627 verbose stack Exit status 1
14627 verbose stack at EventEmitter. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
14627 verbose stack at EventEmitter.emit (events.js:189:13)
14627 verbose stack at ChildProcess. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
14627 verbose stack at ChildProcess.emit (events.js:189:13)
14627 verbose stack at maybeClose (internal/child_process.js:970:16)
14627 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
14628 verbose pkgid storage-engine@3.0.7
14629 verbose cwd /Users/pavel/IdeaProjects/AWS_CodeCommit/google-assistant-tasks
14630 verbose Darwin 13.4.0
14631 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "i" "-g" "firebase-tools"
14632 verbose node v10.15.1
14633 verbose npm v6.14.5
14634 error code ELIFECYCLE
14635 error errno 1
14636 error storage-engine@3.0.7 postinstall: node ./compatibility/detect.js
14636 error Exit status 1
14637 error Failed at the storage-engine@3.0.7 postinstall script.
14637 error This is probably not a problem with npm. There is likely additional logging output above.
14638 verbose exit [ 1, true ]

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[maikelsgit]

Same issue here!

[voiceactivity]

Yes, I can confirm that as well. It doesn't work either ☹️

…

On Mon, 22 Jun 2020, 04:09 Jarvey, ***@***.***> wrote: Same issue here! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2383 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPC26IA7L645SQQQ3D4GTLRXYWD5ANCNFSM4ODZN2DQ> .

[ghost]

Hi, I confirm this issue. firebase tool was removed after the latest update via npm.

[nuthinking]

The issue is with a dependency, even downgrading to 8.0.2 now fails. Which dependency is it? Despite the error, it doesn't look like storage-engine was just updated. firebase-action looks like it solved it by specifying a new node version but that didn't work for me. Ideas?

[kleiteimc]

Ran into the same problem too. 🙁

[anthonycollinnadeau]

Same here... We install firebase-tools in our ci for deployment I tried to change node version 14.4 to 12.18 and change firebase-tools 8.4.3 to 8.4.2 and 8.3.0 they not seem to work either

[robyedlin]

👍 Same problem.

[vsaravind007]

Same issue on Node Version v12.14.1

[davidturtle]

Same.
8.4.2->8.4.3.

[Mistic92]

Same when running on CI where fresh build is done.

 $ npm install -g firebase-tools
 npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.2 (node_modules/firebase-tools/node_modules/chokidar/node_modules/fsevents):
 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
 npm ERR! code ENOENT
 npm ERR! syscall spawn git
 npm ERR! path git
 npm ERR! errno ENOENT
 npm ERR! enoent Error while executing:
 npm ERR! enoent undefined ls-remote -h -t ssh://git@github.com/DABH/diagnostics.git
 npm ERR! enoent 
 npm ERR! enoent 
 npm ERR! enoent spawn git ENOENT
 npm ERR! enoent This is related to npm not being able to find a file.
 npm ERR! enoent 
 npm ERR! A complete log of this run can be found in:
 npm ERR!     /root/.npm/_logs/2020-06-22T12_04_00_184Z-debug.log

[samtstern]

Thanks everyone for the reports. Looks like there's something seriously going wrong here although we don't quite know what yet. Will look into it today.

[samtstern]

Clearly has something to do with this package:
https://www.npmjs.com/package/storage-engine

Last published 10 months ago so not a recent update issue. But there's a big uptick in downloads recently:

The only package that depends on it is this one:
https://www.npmjs.com/package/diagnostics

Running npm ls storage-engine gives me no results but I'm going to try removing my package-lock.json and node_modules to see if that changes.

[samtstern]

Ok we do have a dependency on diagnostics:

firebase-tools@8.4.3 /Users/samstern/Projects/firebase-tools
└─┬ winston@3.3.1
  └── diagnostics@2.0.2

Which means we're getting the storage-engine dep from here:
https://github.com/3rd-Eden/diagnostics/blob/master/package.json#L60

Now I just need to determine what changed recently and what to do about it.

[samtstern]

Ok here's the root cause;
winstonjs/winston#1814

Looks like a dependency of winston now requires git to be installed. The workaround is to make sure you have git on your machine although obviously we need to find a more permanent solution.

[samtstern]

@nuthinking I am not sure what "using the CLI manually" means but yes anything to do with admin.firebase.com is not related to this issue.

[samtstern]

Ok winston has released version 3.3.2 which I think should fix everything as long as you reinstall the Firebase CLI. Thanks everyone for your patience, that was a wild ride!

[voiceactivity]

Fixed!
Thank you team for a very quick action!

[davidturtle]

Thx!

[moryapant]

how it is fixed? can someone please explain?