Missing dependency - on-finished

[segevsh]

[REQUIRED] Environment info

**firebase-tools:**13.23.1

**Platform:**macOS

[REQUIRED] Test case

Firebase Data Connect VS extension errors out with Error: Cannot find module 'on-finished'

[REQUIRED] Steps to reproduce

Simply run the extension, any command (init dataconnect , start emulator, etc...)

[REQUIRED] Expected behavior

should either complete the task, or fail for environmental reasons.

[REQUIRED] Actual behavior

Executing task: npx -y firebase-tools@latest init dataconnect --project fiteasy-7aa8d

node:internal/modules/cjs/loader:1093
throw err;
^

Error: Cannot find module 'on-finished'
Require stack:

• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/finalhandler/index.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/application.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/express.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/index.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/functionsEmulator.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/controller.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/commandUtils.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/database-get.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/index.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/index.js
• /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/bin/firebase.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1090:15)
  at Module._load (node:internal/modules/cjs/loader:934:27)
  at Module.require (node:internal/modules/cjs/loader:1157:19)
  at require (node:internal/modules/helpers:119:18)
  at Object. (/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/finalhandler/index.js:17:18)
  at Module._compile (node:internal/modules/cjs/loader:1275:14)
  at Module._extensions..js (node:internal/modules/cjs/loader:1329:10)
  at Module.load (node:internal/modules/cjs/loader:1133:32)
  at Module._load (node:internal/modules/cjs/loader:972:12)
  at Module.require (node:internal/modules/cjs/loader:1157:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/finalhandler/index.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/application.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/express.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/index.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/functionsEmulator.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/controller.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/commandUtils.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/database-get.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/index.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/index.js',
  '/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/bin/firebase.js'
  ]
  }

Node.js v19.7.0

• The terminal process "/bin/zsh '-l', '-c', 'npx -y firebase-tools@latest init dataconnect --project fiteasy-7aa8d'" terminated with exit code: 1.
• Terminal will be reused by tasks, press any key to close it.

[aalej]

Hey @segevsh, sorry to hear you encountered this issue and thanks for reaching out. I’m trying to reproduce this, but so far the Firebase Data Connect VS extension hasn’t raised any errors after starting the emulators or init dataconnect.

Just to verify, are you able to run the commands(firebase init and/or firebase emulators:start) using the Firebase CLI, or does it also raise a similar error? It may be worth trying to re-install the extension, and I'd also recommend using an LTS(even-numbered) version of Node(e.g., 18, 20).

[segevsh]

I'm able to run `firebase init` and `firebase emulators` I keep my cli up to date which means I just re-installed it a day or two ago (as well as the extension). I was able to fix it by creating the hub file manually (in the os temp folder). So now I'm able to both run it from my local and connect to our emulators that are running on docker.

…

On Wed, Nov 6, 2024 at 7:45 AM aalej ***@***.***> wrote: Hey @segevsh <https://github.com/segevsh>, sorry to hear you encountered this issue and thanks for reaching out. I’m trying to reproduce this, but so far the Firebase Data Connect VS extension hasn’t raised any errors after starting the emulators or init dataconnect. Just to verify, are you able to run the commands(firebase init and/or firebase emulators:start) using the Firebase CLI, or does it also raise a similar error? It may be worth trying to re-install the extension, and I'd also recommend using an LTS(even-numbered) version of Node(e.g., 18, 20). — Reply to this email directly, view it on GitHub <#7900 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASPB37TIE55NOAZAAS4J2LZ7IFQPAVCNFSM6AAAAABRCYL2QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZGY3DCNJYGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>