-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added project and app management commands and firebase init updates #1562
Merged
+2,612
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecm
requested changes
Aug 1, 2019
* Implement api calls to support project creation * Initial working command * Replace nock with sinon to mock api requests * export createFirebaseProject() and update tests * Implement projects:create command * Remove poll helper methods * Rename firebase-resource-manager.ts to projectsCreate.ts * Declare project and app metadata types * Update timeout constant * Update unit tests as suggestion * Split metadata.ts into apps.ts and projects.ts * move code to projects.ts * Addressing comment
* Implement API calls for apps:create command * Implement apps:create command * Remove --sha-certificate option * Support providing appStoreId for iOS app creation * Update the command to use getProjectId() * Update unit tests as suggestion * move code to apps.ts * Add input options interfaces and getAppPlatform
* Implement projects:list command * Matching changes from metadata * Move code to projects.ts * Resolving TODO
* Implement apps:list command * Introducing AppPlatform.ANY and code refactoring * Move code to apps.ts
) * Implement getFirebaseProject and deprecate firebaseApi * Implement getProjectPage() and refactor listFirebaseProject() * Implement use an existing project option * Update behavior when there's no project * Implement "Create a new project" option (#1510)
* Logging total project count after listing. * Logging total app count
* Implement API methods for apps:sdkconfig * Implement apps:sdkconfig command
rosecm
approved these changes
Aug 1, 2019
bkendall
requested changes
Aug 1, 2019
bkendall
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented project and app management commands to the Firebase CLI and
firebase init
command improvements as approved in the API proposal (go/firebase-cli-project-management).Change Details
New Commands
projects:create
: Create a new Firebase project (#1429)projects:list
: List all Firebase projects belonged to the logged in user (#1465, #1526)apps:create
: Create a new Firebase app (#1438)apps:list
: List apps belonged to an accessible Firebase project (#1477, #1526)apps:sdkconfig
: print the Google Services config of a Firebase app (#1515)Improvement
firebase init
: Improved default project setup flow, starting with the 3 setup choices (#1506)-
[Create a new project]
option: create and set a new project as the default project of the current directory-
[Use an existing project]
option: Prompt user for an existing project (choose from the list of projects or prompting for project ID if there're too many projects)-
[Do not set up a default project]
option: Defer setting up default projectOther cleanup:
src/management/projects.ts
andsrc/management/apps.ts
(Declare project and app metadata types #1470)Testing
Upcoming work
firebase list
command after the introduction offirebase projects:list
commandfirebase projects:addfirebase
to add Firebase to an existing GCP project