Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt for location on mods:configure #1566

Merged
merged 21 commits into from
Aug 13, 2019
Merged

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Jul 30, 2019

Description

No longer prompt for location on mods:configure - instead, pass in the current location. Trying to change location will throw a 400 error every time.

Scenarios Tested

Mods:install still prompts for location:
Screen Shot 2019-07-30 at 10 25 08 AM

mods:configure no longer does:
Screen Shot 2019-07-30 at 10 26 28 AM

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 30, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 63.922% when pulling 2710909 on jh-no-configure-location into 509a49b on master.

@coveralls
Copy link

coveralls commented Jul 30, 2019

Coverage Status

Coverage remained the same at 64.829% when pulling 9a0630f on jh-no-configure-location into f0f2f26 on master.

@joehan joehan requested review from laurenzlong and bkendall July 30, 2019 17:39
@joehan joehan requested a review from bkendall July 30, 2019 23:07
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of naming, but looks fine otherwise.

@joehan joehan requested a review from bkendall August 1, 2019 16:24
@joehan joehan requested a review from bkendall August 6, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants