Fix functions deploy integration test script #1703
Conversation
| exports.dbAction = functions.database.ref("/input/{uuid}").onWrite(function(event) { | ||
| console.log("Received event:", event); | ||
| return event.data.ref.root.child("output/" + event.params.uuid).set(event.data.val()); | ||
| exports.dbAction = functions.database.ref("/input/{uuid}").onCreate(function(snap, context) { |
There was a problem hiding this comment.
just curious about why the switch from onWrite to onCreate for this
There was a problem hiding this comment.
So the function receives a Snapshot, instead of a Change object. (We didn't need the "before" and "after" that Change provides.)
| "firebase": "^3.5.0", | ||
| "firebase-admin": "latest", | ||
| "firebase-functions": "latest" | ||
| "firebase": "^3.5.0" |
There was a problem hiding this comment.
is this package.json file actually required? If the script is run node scripts/test-functions-deploy.js, and firebase is already a dev dependency of the package, then do we need to keep this file around?
| @@ -25,9 +25,6 @@ var functionsConfig = require("../lib/functionsConfig"); | |||
|
|
|||
| var clc = require("cli-color"); | |||
| var firebase = require("firebase"); | |||
There was a problem hiding this comment.
I'm fairly certain that firebase in the root package.json is really, really, really, really old - it would be great if it was updated. (This file is the only requirement for having firebase as a dependency - I've looked - so since you're updating it...)
* master: change out tslint for eslint, new publish config (firebase#486) Remove scripts/package.json and update firebase version. (firebase#1704) Fix functions deploy integration test script (firebase#1703) Loop the modules properties without prototype methods. Fixes firebase#1687 (firebase#1694) Allow customers to configure the db setting 'strictTriggerValidation' (firebase#1702) [firebase-release] Removed change log and reset repo after 7.5.0 release 7.5.0 Fix export users (firebase#1690) Fix port issues in WSL (firebase#1699) Unremove but deprecate separate port for WebChannel. (firebase#1698) Release Firestore Emulator 1.9.0 and remove WebChannel workaround. (firebase#1689) update handlebars dependency (firebase#1686) [firebase-release] Removed change log and reset repo after 7.4.0 release 7.4.0 remove items from previews list (firebase#488)
Description
Several fixes to the integration test:
Scenarios Tested
node scripts/test-functions-deploy.js. Result below.