Support for functions failure policies

[samtstern]

Description

Fixes: #1734
Follow up to: firebase/firebase-functions#482

Depends on:
firebase/firebase-functions#760

Scenarios Tested

Testing using three functions:

const functions = require('firebase-functions');
const admin = require('firebase-admin');
admin.initializeApp();

exports.policyEmptyObject = functions
  .runWith({
    failurePolicy: { retry: {} }
  })  
  .pubsub.topic("retry-topic")
  .onPublish((msg, ctx) => {
    return true;
  });


exports.policyTrue = functions
  .runWith({
    failurePolicy: true,
  })
  .pubsub.topic("retry-topic")
  .onPublish((msg, ctx) => {
    return true;
  });

exports.policyNone = functions
  .pubsub.topic("retry-topic")
  .onPublish((msg, ctx) => {
    return true;
  });

Sample Commands

N/A

[rhodgkins]

Any ideas what's happened to this - is it still having to go through an API review or something? Would be great to see it out and released!

[merlinnot]

@rhodgkins This stopped at #1734 (comment), I never heard of this issue being fixed. @samtstern Could you check if it's fixed?

[samtstern]

@merlinnot I still have not been able to get the issue with the Functions backend resolved. But there's always a chance someone fixed the backend without knowing, I'll give this another run today.

[merlinnot]

Awesome!

[samtstern]

@merlinnot I'm having some real trouble testing this ... It's been a while but I think I need to:

1. Checkout firebase-functions and switch to the branch with failurePolicy
2. In firebase-tools I need to npm install --save ../firebase-functions to get my local version
3. In my Firebase functions folder (test project) I need to find a way to bundle firebase-functions so that my local dependency is uploaded at firebase deploy

(2) and (3) are failing in fun ways

Have you ever tried to test this end-to-end? Am I making this harder on myself than it needs to be?

---

Edit: @mbleigh has told me about the wonders of npm pack

[samtstern]

@merlinnot it works now! I guess the backend fixed the issue at some point, or I'm doing something differently. But once firebase/firebase-functions#760 is released we can proceed with this.

[merlinnot]

Brilliant! The other PR was already approved and merged once, so we shouldn't have much trouble with landing it 😂

[joehan]

LGTM with one question about wording. 🥳 for this finally working!

[samtstern]

Thanks @joehan ! Could you also take a look at firebase/firebase-functions#760 which is a prerequisite to this PR?

[stari4ek]

BTW, there is no way to enable retries for firebase functions using GCP UI now.
When I enable "Retry on failure" for function with "Cloud Firestore" trigger - it requires to re-deploy function using web UI.
Using already deployed source code ("Inline Editor" selected) gives build error (most probably since it expects google cloud function and does not have any magic applied by firebase cli): Build failed: function.js does not exist; Error ID: 7485c5b6

So it means there is no way to enable retries at all

[samtstern]

firebase-functions version 3.10.0 is out which contains this feature. Tests are passing and an end-to-end test worked on my end! Going to merge!

[armordog]

Should this check if there are any functions with a retry policy?

[samtstern]

Ooooh ... I think so! Want to send a PR?

[samtstern]

(or I can do it, but you deserve the glory)

[armordog]

I appreciate the opportunity but I have a lot to do right now. =]

[samtstern]

@armordog done and released!
https://github.com/firebase/firebase-tools/releases/tag/v8.8.1

Thank you for catching that! Saved me a lot of angry emails in the morning :-)

[armordog]

That was fast!
Thanks so much. =]