Introduce some metaprogramming types #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Apr 13, 2022
src/functional.ts
Outdated
| @@ -1,18 +1,20 @@ | |||
| import { SameType, LeafElems } from "./metaprogramming"; | |||
There was a problem hiding this comment.
per linter: 'SameType' is defined but never used
src/metaprogramming.ts
Outdated
| : T[Key] extends object | ||
| ? `${Key}` | `${Key}.${RecursiveKeyOf<T[Key]>}` | ||
| : `${Key}`; | ||
| }[keyof T & (string | number)]; |
There was a problem hiding this comment.
lol I like how you broke syntax highlighting in github UI:
src/metaprogramming.ts
Outdated
| [Key in keyof T & (string | number)]: T[Key] extends unknown[] | ||
| ? `${Key}` | ||
| : T[Key] extends object | ||
| ? `${Key}` | `${Key}.${RecursiveKeyOf<T[Key]>}` |
There was a problem hiding this comment.
One concern - latest version of typescript does not like this:
Type instantiation is excessively deep and possibly infinite.(2589)
Try running it on lower version - no problems there!
Here's a response from the TS team about this regression:
microsoft/TypeScript#48552 (comment)
In fact, the example they are using (DeepKeys) looks identical (except that it also support union of objects too?)
Comment on lines
+55
to
+58
| type RecursiveElems<T extends unknown[]> = { | ||
| [Key in keyof T]: T[Key] extends unknown[] ? T[Key] | RecursiveElems<T[Key]> : T[Key]; | ||
| }[number]; | ||
|
|
There was a problem hiding this comment.
Think we don't need this anymore.
| * const test: SameType<A, B> = true. | ||
| * The assigment will fail if the types are different. | ||
| */ | ||
| export type SameType<T, V> = T extends V ? (V extends T ? true : false) : false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blood is on your hands @taeold 😉