Load secrets when emulating functions with --inspect-function flag #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Dec 7, 2022
Comment on lines
+662
to
+669
| toSetup.reduce( | ||
| (acc: Record<string, backend.SecretEnvVar>, curr: EmulatedTriggerDefinition) => { | ||
| for (const secret of curr.secretEnvironmentVariables || []) { | ||
| acc[secret.key] = secret; | ||
| } | ||
| return acc; | ||
| }, | ||
| {} |
There was a problem hiding this comment.
(no action required) ohhh reduce is so hard for me. I think I always just end up writing a for loop.
|
Secrets are loaded at emulator startup with the " --inspect-functions" flag, but hot reloads (changing the code and watch reloads) cause the secrets to return to undefined. The emulator needs to then be restarted for the secrets to load again. @joehan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load secrets when emulating functions with --inspect-function flag. Fixes #4605 and #5062
Scenarios Tested
Tested that extensions and CF3 codebases correctly load secrets, both with and without the --inspect-functions flag.