Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leoortizz nextjs rewrites #5316

Merged
merged 59 commits into from
Dec 9, 2022
Merged

Leoortizz nextjs rewrites #5316

merged 59 commits into from
Dec 9, 2022

Conversation

jamesdaniels
Copy link
Member

Googler mirror of #5212 for integration tests

also, clean escaped chars from supported `sources`
`replaceAll` is not supported by Node.js 14
... routes regexes from CDN

additionally more reusable utils and types
@jamesdaniels jamesdaniels enabled auto-merge (squash) December 9, 2022 03:41
@codecov-commenter
Copy link

Codecov Report

Base: 56.34% // Head: 56.31% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4b505c5) compared to base (97ce550).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5316      +/-   ##
==========================================
- Coverage   56.34%   56.31%   -0.04%     
==========================================
  Files         310      312       +2     
  Lines       20932    20982      +50     
  Branches     4255     4267      +12     
==========================================
+ Hits        11795    11816      +21     
- Misses       8113     8141      +28     
- Partials     1024     1025       +1     
Impacted Files Coverage Δ
src/frameworks/next/index.ts 12.50% <4.87%> (-0.92%) ⬇️
src/frameworks/utils.ts 80.00% <80.00%> (ø)
src/frameworks/next/utils.ts 88.23% <88.23%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesdaniels jamesdaniels merged commit cbe5790 into master Dec 9, 2022
@jamesdaniels jamesdaniels deleted the leoortizz_nextjs_rewrites branch December 9, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants