Upgrade tooling to node 18, remove explicit support for node 14 #5730
Conversation
|
Tests are currently broken due to a known issue wuth unzipper. #5714 should fix this, need to revist once that is in. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## next #5730 +/- ##
==========================================
+ Coverage 55.36% 55.40% +0.04%
==========================================
Files 331 331
Lines 22727 23073 +346
Branches 4632 4768 +136
==========================================
+ Hits 12582 12784 +202
- Misses 9027 9171 +144
Partials 1118 1118 ☔ View full report in Codecov by Sentry. |
|
Spent a bunch of time debugging the import-export integration test, to no avail. I'm increasingly convinced that we need to redesign it to be less fragile - it currently spins up and tears down the emulators 6 times, and has a hard coded wait between each. However, the test cases are consistently overlapping and causing it to fail. |
|
It would be really helpful to me, and probably to others, if the discontinuation of Node.js 14 support was mentioned in the 12.0.0 release notes. Thanks! |
|
@Igloczek good call. Done. 🙂 |
* Upgrade tooling to node 18, remove explicit support for node 14 * Add log to debug broken test * formats * Fix functions-discovery tests * Fix functions-discover tests * Try longer wait for import/export test * Keep import-export on node 16 * check if npm 9 is the issue * Comment out import-export for now * flex my ip resolution knowledge by using a resolver * reinstate import-export test --------- Co-authored-by: Bryan Kendall <bkend@google.com>
Description
Upgrades tooling to node 18, removes explicit support for node 14