Skip to content

Limit web frameworks generated functionId to 20 chars max #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Limit web frameworks generated functionId to 20 chars max #6260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fb3f16
Limit web frameworks generated functionId to 20 chars max
alexastrum Aug 15, 2023
9aef05f
Merge branch 'master' into alexastrum-fixlongname
alexastrum Aug 16, 2023
d964bd7
Merge branch 'master' into alexastrum-fixlongname
jamesdaniels Dec 7, 2023
614d7ad
Merge branch 'master' into alexastrum-fixlongname
jamesdaniels Dec 7, 2023
ededd2d
Add changelog
jamesdaniels Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)
- Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562)
- Use Web Framework's well known version range in `firebase init hosting`. (#6562)
- Limit Web Framework's generated Cloud Function name to 20 characters, fixing deploys for some. (#6260)
3 changes: 2 additions & 1 deletion src/frameworks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ export async function prepareFrameworks(
);
}
const getProjectPath = (...args: string[]) => join(projectRoot, source, ...args);
const functionId = `ssr${site.toLowerCase().replace(/-/g, "")}`;
// Combined traffic tag (19 chars) and functionId cannot exceed 46 characters.
const functionId = `ssr${site.toLowerCase().replace(/-/g, "").substring(0, 20)}`;
const usesFirebaseAdminSdk = !!findDependency("firebase-admin", { cwd: getProjectPath() });
const usesFirebaseJsSdk = !!findDependency("@firebase/app", { cwd: getProjectPath() });
if (usesFirebaseAdminSdk) {
Expand Down