Skip to content

Fix Issue #6382 Firebase not working for NextJs >=v13.5.0 #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix Issue #6382 Firebase not working for NextJs >=v13.5.0 #6404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b513b29
Fix Issue #6382 Firebase not working for NextJs >=v13.5.0
Ferido07 Sep 20, 2023
d23073d
Changelog
joehan Sep 26, 2023
af32cea
Merge branch 'master' into nextjs-deploy-bug-fix1
joehan Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Improve performance and reliability when deploying multiple 2nd gen functions using single builds. (#6376)
- Fixed an issue where `emulators:export` did not check if the target folder is empty. (#6313)
- Fix "Could not find the next executable" on Next.js deployments (#6372)
- Fixed "Could not find the next executable" on Next.js deployments (#6372)
- Fixed issues caused by breaking changes in Next >=v13.5.0. (#6382)
2 changes: 1 addition & 1 deletion src/frameworks/next/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ async function getConfig(
if (gte(version, "12.0.0")) {
const { default: loadConfig } = relativeRequire(dir, "next/dist/server/config");
const { PHASE_PRODUCTION_BUILD } = relativeRequire(dir, "next/constants");
config = await loadConfig(PHASE_PRODUCTION_BUILD, dir, null);
config = await loadConfig(PHASE_PRODUCTION_BUILD, dir);
} else {
try {
config = await import(pathToFileURL(join(dir, "next.config.js")).toString());
Expand Down