Skip to content

Fix blocking functions in the emulator when using multiple codebases #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix blocking functions in the emulator when using multiple codebases #6504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
668ed0c
fix emulator bug
colerogers Nov 9, 2023
af14d78
Add changelog entry
colerogers Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix blocking functions in the emulator when using multiple codebases (#6504).
4 changes: 2 additions & 2 deletions src/emulator/functionsEmulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,6 @@ export class FunctionsEmulator implements EmulatorInstance {
} else {
this.workerPools[emulatableBackend.codebase].refresh();
}
// reset blocking functions config for reloads
this.blockingFunctionsConfig = {};

// When force is true we set up all triggers, otherwise we only set up
// triggers which have a unique function name
Expand Down Expand Up @@ -1436,6 +1434,8 @@ export class FunctionsEmulator implements EmulatorInstance {

async reloadTriggers() {
this.triggerGeneration++;
// reset blocking functions config for reloads
this.blockingFunctionsConfig = {};
for (const backend of this.args.emulatableBackends) {
await this.loadTriggers(backend);
}
Expand Down