Skip to content

ng-deploy may not have configurations configured... #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 7, 2023
Merged

ng-deploy may not have configurations configured... #6584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
548fd34
ng-deploy may not have configurations configured...
jamesdaniels Dec 7, 2023
ac07128
Changelog
jamesdaniels Dec 7, 2023
a49a6d4
Pull serveTarget
jamesdaniels Dec 7, 2023
e9f7316
Default should be development
jamesdaniels Dec 7, 2023
e8ce027
Default to prod
jamesdaniels Dec 7, 2023
816bde3
Use target name, incase it was an override
jamesdaniels Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)
8 changes: 7 additions & 1 deletion src/frameworks/angular/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ export async function getContext(dir: string, targetOrConfiguration?: string) {
}

if (deployTarget) {
const options = await architectHost.getOptionsForTarget(deployTarget);
const options = await architectHost
.getOptionsForTarget(deployTarget)
.catch(() => workspaceProject.targets.get(deployTarget!.target)?.options);
if (!options) throw new FirebaseError("Unable to get options for ng-deploy.");
if (options.buildTarget) {
assertIsString(options.buildTarget);
Expand All @@ -238,6 +240,10 @@ export async function getContext(dir: string, targetOrConfiguration?: string) {
assertIsString(options.serverTarget);
serverTarget = targetFromTargetString(options.serverTarget);
}
if (options.serveTarget) {
assertIsString(options.serveTarget);
serveTarget = targetFromTargetString(options.serveTarget);
}
if (options.serveOptimizedImages) {
serveOptimizedImages = true;
}
Expand Down