Skipping partial html files generated due to enabling ppr in Nextjs #7625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move common logic to utils functions
…osalvador/fix-next-ppr-dynamic-pages
jamesdaniels
reviewed
Oct 3, 2024
jamesdaniels
reviewed
Oct 3, 2024
src/frameworks/next/index.ts
Outdated
|
|
||
| const sourcePath = join(contentDist, ...sourcePartsOrIndex); | ||
|
|
||
| if (await isPartialHTML(`${sourcePath}.html`)) { |
There was a problem hiding this comment.
Let's test if .html exists first, that should reduce some of the cost
…:firebase/firebase-tools into chalosalvador/fix-next-ppr-dynamic-pages
leoortizz
reviewed
Oct 8, 2024
…osalvador/fix-next-ppr-dynamic-pages
jamesdaniels
requested changes
Oct 14, 2024
jamesdaniels
approved these changes
Oct 23, 2024
leoortizz
reviewed
Oct 24, 2024
leoortizz
reviewed
Oct 24, 2024
leoortizz
approved these changes
Oct 24, 2024
…osalvador/fix-next-ppr-dynamic-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When partial pre-rendering (
experimental: {ppr: true}is enabled innext.config.jsNext.js includes dynamic pages in theprerender-manifest.jsonand it generates the.htmlfiles with partial html and those files are copied over by firebase to the hosting folder causing the pages to render empty or invalid html pages.This PR add a check to skip partial html files from being copies over to the hosting folder.
Scenarios Tested
Sample Commands