Skip to content

Conversation

@AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented Sep 23, 2022

Description

The C++ version input was being ignored and empty string was set instead.


Testing

Ran this workflow and verified that the Print Outputs step printed outputs.firebase_cpp_sdk_version as a non-empty string
https://github.com/firebase/firebase-unity-sdk/actions/runs/3115233731/jobs/5051915301


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@AlmostMatt AlmostMatt merged commit be9487b into main Sep 23, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 23, 2022
@github-actions
Copy link

github-actions bot commented Sep 23, 2022

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 9729a02
Last updated: Fri Sep 23 21:33 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
auth [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]
firestore [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
[TEST] [FAILURE] [2019] [macos] [1/6 Platform(s): windows]
functions [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
installations [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
messaging [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]
[TEST] [FAILURE] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
remote_config [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
storage [TEST] [FAILURE] [2019] [macos] [2/6 Platform(s): ubuntu windows]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 24, 2022
@AlmostMatt AlmostMatt deleted the almostmatt-build-workflow-cpp-version branch October 20, 2022 21:16
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants