Skip to content

Firestore: Add a test and readme about the android global refs crash #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jul 4, 2023

Add a test and release notes entry for a fix to an intermittent crash in Firestore on Android when large documents and/or a large number of documents with large arrays or maps were used. See #569 and firebase/firebase-cpp-sdk#1364 for details.

@dconeybe dconeybe self-assigned this Jul 4, 2023
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jul 4, 2023
@dconeybe
Copy link
Contributor Author

dconeybe commented Jul 5, 2023

Integration tests: https://github.com/firebase/firebase-unity-sdk/actions/runs/5459341301
Update: Tests failed because I failed to enable auth (I only enabled firestore, which has a dependency on auth)

@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 5f6bc14
Last updated: Wed Jul 5 11:09 PDT 2023
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [2020] [1/2 Build OS(s): macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 5, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 5, 2023
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jul 5, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 5, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 5, 2023
@dconeybe dconeybe requested a review from wu-hui July 5, 2023 18:13
@wu-hui wu-hui merged commit 1793ca8 into main Jul 5, 2023
@dconeybe dconeybe deleted the dconeybe/AndroidGlobalRefsFixTest branch July 5, 2023 18:38
@firebase firebase locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants