Skip to content

Add test for new Analytics conversion feature #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2023
Merged

Add test for new Analytics conversion feature #841

merged 1 commit into from
Aug 21, 2023

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Aug 17, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

The C++ SDK is adding a new Analytics function for phone number conversion, which will automatically be added to the Unity SDK due to swig. firebase/firebase-cpp-sdk#1429

This adds it to the test, and the readme.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov August 17, 2023 17:40
@a-maurice a-maurice merged commit 43edcc6 into main Aug 21, 2023
@a-maurice a-maurice deleted the am-analytics_conversion branch August 21, 2023 16:51
@firebase firebase locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov