Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [firebase_auth] Not compatible with intl version latest #10199

Closed
zakblacki opened this issue Dec 31, 2022 · 17 comments · Fixed by #10944
Closed

🐛 [firebase_auth] Not compatible with intl version latest #10199

zakblacki opened this issue Dec 31, 2022 · 17 comments · Fixed by #10944
Labels
plugin: auth resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working

Comments

@zakblacki
Copy link

Please upgrade firebase_auth with intl 0.18

Because firebase_auth >=4.2.4 depends on firebase_auth_web ^5.2.4 which depends on intl ^0.17.0, firebase_auth >=4.2.4 requires intl ^0.17.0.

@zakblacki zakblacki added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Dec 31, 2022
@darshankawar darshankawar added the triage Issue is currently being triaged. label Jan 2, 2023
@darshankawar
Copy link

Thanks for the report. Using plugin example, if we run flutter pub add intl, it by default adds intl: ^0.17.0. But if we manually try to add intl: ^0.18.0, it gives below compile error:

Because every version of firebase_auth_web from path depends on intl ^0.17.0 and firebase_auth_example depends on intl ^0.18.0, firebase_auth_web from path is forbidden.
So, because firebase_auth_example depends on firebase_auth_web from path, version solving failed.
pub get failed
command: "/Users/dhs/Documents/Fluttersdk/flutter/bin/cache/dart-sdk/bin/dart __deprecated_pub --directory . get --example"
pub env: {
  "FLUTTER_ROOT": "/Users/dhs/Documents/Fluttersdk/flutter",
  "PUB_ENVIRONMENT": "flutter_cli:get",
  "PUB_CACHE": "/Users/dhs/.pub-cache",
}
exit code: 1

Process finished with exit code 1

firebase_auth_web seems to depend on intl: ^0.17.0 as shown below:

Screenshot 2023-01-02 at 4 19 26 PM

@darshankawar darshankawar added plugin: auth and removed Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Jan 2, 2023
@darshankawar
Copy link

/cc @Lyokone

@Lyokone
Copy link
Contributor

Lyokone commented Jan 2, 2023

@zakblacki We reverted the upgrade to intl 0.18 since it was incompatible with flutter_localization. I guess you are on the master channel. You can force override to intl 0.18 if needed or go back to stable.

@Sun3
Copy link

Sun3 commented Mar 28, 2023

Any updates on this issue? We should be able to use intl ^0.18.0

Thank you.

@Lyokone
Copy link
Contributor

Lyokone commented Mar 28, 2023

If you need to use ^0.18.0 you can always use dependency override to force the update. As long as the stable version is 3.7, we can only ship the intl version that is compatible with flutter_localization :)

@Sun3
Copy link

Sun3 commented Mar 28, 2023

I understand... I am hoping in the near future the firebase_auth will upgrade to intl ^0.18.0

Thanks.

@jhonatan-3a
Copy link

any updates on this one ?

@Lyokone
Copy link
Contributor

Lyokone commented Apr 19, 2023

No new stable version of Flutter has been released, so we are still using 0.17.0. As said before, you can use

dependency_overrides:
  intl: ^0.18.0

if you really need the latest version (it should not be breaking with previous release)

@Fraa-124
Copy link

Fraa-124 commented May 10, 2023

I have updated to Flutter 3.10.0 (stable), but I still cannot compile due to the dependency issue with firebase_auth 4.5.0, which relies on firebase_auth_web 5.4.0. In turn, firebase_auth_web 5.4.0 depends on intl 0.17.0, while flutter_localizations depends on intl 0.18.0.

Is it really that difficult to update firebase_auth_web to use intl 0.18.0?

@MagnusJohansson
Copy link

MagnusJohansson commented May 10, 2023

Now that Flutter 3.10 /Dart 3.0.0 stable is out, I think it's time to wake up and finally update [firebase_auth] to use intl 0.18.0

Because firebase_auth >=4.5.0 depends on firebase_auth_web ^5.4.0 which depends on intl ^0.17.0, firebase_auth >=4.5.0 requires intl ^0.17.0.
So, because my_app depends on both firebase_auth >=4.5.0 and intl >=0.18.0, version solving failed.

And, of course, as you know, when using flutter 3.10.0 with flutter_localizations one can't use intl 0.17.0 anymore.

Because my_app  depends on flutter_localizations from sdk which depends on intl 0.18.0, intl 0.18.0 is required.
So, because my_app depends on intl ^0.17.0, version solving failed.

So, please update [firebase_auth] / [firebase_auth_web] to be Flutter 3.10 / Dart 3.0.0 compatible.

@Yegorisa
Copy link

Agree with the last post, we can't compile the project at all with flutter 3.10.0 because of this issue

@Lyokone
Copy link
Contributor

Lyokone commented May 11, 2023

I've opened #10944 to update the last few things needed for Flutter 3.10.0. I hope you understand that we couldn't update to intl 0.18.0 before the stable release last night.

It is not that it's "really that difficult to update"

Again, you can always override your dependencies if you cannot wait for a library to update.

dependency_overrides:
  intl: ^0.18.1

@BirjuVachhani
Copy link

Overriding it didn't work for me. I had to add this as well in addition to the dependency_overrides

dependencies:
  flutter_localizations:
    sdk: flutter

@Lyokone
Copy link
Contributor

Lyokone commented May 11, 2023

We will shortly deploy a new version. This new version will not depend on intl anymore, so it will not cause any issues in the future.

@jhonatan-3a
Copy link

jhonatan-3a commented May 11, 2023

thank programming gods its no longer dependant on intl anymore, kudos!

@Lyokone
Copy link
Contributor

Lyokone commented May 11, 2023

It's published as part of firebase_auth: ^4.6.0

@jhonatan-3a
Copy link

awesomees

@darshankawar darshankawar added the resolution: fixed A fix has been merged or is pending merge from a PR. label May 12, 2023
@firebase firebase locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: auth resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants