feat: update librairies to be compatible with Flutter 3.10.0 #10944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Rexios80
reviewed
May 11, 2023
| @@ -17,7 +17,7 @@ dependencies: | |||
| flutter_web_plugins: | |||
| sdk: flutter | |||
| http_parser: ^4.0.0 | |||
| intl: ^0.17.0 | |||
| intl: ^0.18.1 | |||
There was a problem hiding this comment.
Shouldn't this be ^0.18.0 for compatibility with Flutter? I believe their version is set to 0.18.0.
There was a problem hiding this comment.
True, I'll downgrade to 0.18.0. It would have still resolved properly.
lesnitsky
approved these changes
May 11, 2023
Salakar
approved these changes
May 11, 2023
|
is this already published to the pub dev? asking for a friend |
|
It was just published |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove intl dependency and use JS to parse the date in firebase_auth_web. Fix formatting issues
Related Issues
closes #10199
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?