fix(ui_auth): fix default SMSCodeInputScreen breakpoint #10226
Conversation
| @@ -110,6 +110,7 @@ class SMSCodeInputScreen extends StatelessWidget { | |||
| sideBuilder: sideBuilder, | |||
| headerBuilder: headerBuilder, | |||
| headerMaxExtent: headerMaxExtent, | |||
| contentFlex: contentFlex, | |||
There was a problem hiding this comment.
Shouldn't we have something that can resize the size of the SMS input? I feel like this fix is going to cause another issue for another size
There was a problem hiding this comment.
there are 2 options that allow configuring the behaviour of this screen:
breakpoint – to have a side content on wide screens and header on narrow
contentFlex – allows configuring the proportion of the side content and content (SMSCodeInput)
These 2 are enough to have SMSCodeInput being displayed correctly on all screens.
The original issue could have been fixed on user's end (passing breakpoint), however the default values should also be usable on all screens – that's why I changed the default value.
In general I don't think it's possible to account for all kinds of layouts in our own screen widget, the library allows building custom screens using lower level widgets – this should be enough.
There was a problem hiding this comment.
Nice to know, I have still a lot to learn about FlutterFire UI
Related Issues
Closes #10212
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?