Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui_auth): fix default SMSCodeInputScreen breakpoint #10226

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix(ui_auth): fix default SMSCodeInputScreen breakpoint #10226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/firebase_ui_auth/lib/src/screens/sms_code_input_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class SMSCodeInputScreen extends StatelessWidget {
this.sideBuilder,
this.headerBuilder,
this.headerMaxExtent,
this.breakpoint = 500,
this.breakpoint = 670,
this.contentFlex,
this.maxWidth,
}) : super(key: key);
Expand Down Expand Up @@ -110,6 +110,7 @@ class SMSCodeInputScreen extends StatelessWidget {
sideBuilder: sideBuilder,
headerBuilder: headerBuilder,
headerMaxExtent: headerMaxExtent,
contentFlex: contentFlex,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have something that can resize the size of the SMS input? I feel like this fix is going to cause another issue for another size

Copy link
Member Author

@lesnitsky lesnitsky Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 options that allow configuring the behaviour of this screen:
breakpoint – to have a side content on wide screens and header on narrow
contentFlex – allows configuring the proportion of the side content and content (SMSCodeInput)

These 2 are enough to have SMSCodeInput being displayed correctly on all screens.
The original issue could have been fixed on user's end (passing breakpoint), however the default values should also be usable on all screens – that's why I changed the default value.

In general I don't think it's possible to account for all kinds of layouts in our own screen widget, the library allows building custom screens using lower level widgets – this should be enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to know, I have still a lot to learn about FlutterFire UI

child: Column(
mainAxisSize: MainAxisSize.min,
children: [
Expand Down