[firebase_auth] errors codes are incorrect

[ollyde]

Previously we had error codes working correctly on signup/login. Now the errors codes thrown are different. We didn't know until users were complaining about it.

When was this deprecated? And why wasn't it done correctly?

Example of previous error pickup =

if (e is PlatformException) {
      if (e.code == 'ERROR_EMAIL_ALREADY_IN_USE') {
           message = lang('error_email_already_in_use');
      }
      if (e.code == 'ERROR_WEAK_PASSWORD') {
           message = 'The password was weak, try another. Perhaps longer with more special characters.';
      }
      if (e.code == 'ERROR_INVALID_EMAIL') {
           message = lang('error_invalid_email_signup');
     }
}

Now the error codes throw look like this: firebase/EMAIL_ALREADY_IN_USE

[dackers86]

HI @OllyDixon

Our documentation shows that your original code is correct (https://firebase.flutter.dev/docs/auth/usage/#emailpassword-registration--sign-in). Can you confirm which version of auth you are using.

We have templates for correctly tracking and issues https://github.com/FirebaseExtended/flutterfire/issues/new/choose.

Using this will support in finding the issue. Thanks!

[ollyde]

I'm using firebase_auth: 0.18.0 the original no longer works. There is also another auth section with 12 switch cases, I had to change this one to this for now:

    if (e is FirebaseAuthException) {
      if (e.code == 'email-already-in-use') {
        message = lang('error_email_already_in_use');
      }
      if (e.code == 'invalid-email') {
        message = lang('error_invalid_email_signup');
      }
      if (e.code == 'weak-password') {
        message = 'The password was weak, try another. Perhaps longer with special characters.';
      }
    }

[ollyde]

@dackers86 this is a diaster I imagine so many apps using Firebase auth will have silient errors now. This wasn't deprecated with any warnings; previosuly we were told what the values were; now we don't know.

[markusaksli-nc]

Printing FirebaseAuthException.code using firebase_auth: ^0.18.1+2 outputs:

I/flutter ( 4998): email-already-in-use

Can't find anything in the changelog regarding this being changed, aside from 0.18.0:

Added a new FirebaseAuthException class (extends FirebaseException)

[Salakar]

@dackers86 could you send a PR up to add this to the changelog please? Ping me on slack if you need more info. Thanks

[ollyde]

@markusaksli-nc @Salakar we've almost implemented a solution with the new codes (tested them all). Will this be changed again or not? (We really need enums tbh)

[Ehesp]

#3402 there is this PR up, some discussion in there

[Salakar]

Closing in favour of #3273