Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui_shared): pass platform-specific icons and colors explicitly #10655

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

lesnitsky
Copy link
Member

Description

Allows to pass cupertinoColor, materialColor, cupertinoIcon and materialIcon to the UniversalButton and LoadingButton instead of checking isCupertino in the parent each time

Related Issues

none

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

This is technically a breaking change, but firebase_ui_shared wasn't released yet.

@lesnitsky lesnitsky requested review from Lyokone and pr-Mais March 24, 2023 15:32
Copy link
Contributor

@Lyokone Lyokone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be a feat: instead of chore:?

@lesnitsky lesnitsky changed the title chore: pass platform-specific icons and colors explicitly feat(ui_shared): pass platform-specific icons and colors explicitly Mar 27, 2023
@lesnitsky lesnitsky merged commit 60ff1df into master Mar 27, 2023
@lesnitsky lesnitsky deleted the chore/ui-better-platform-buttons branch March 27, 2023 10:47
@firebase firebase locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants