Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-check): fix 'Semantic Issue (Xcode): new is unavailable' on XCode 14.3 #10734

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Apr 6, 2023

Description

The Podfile modifications cannot be moved to the podspec (and are unrelated to AppCheck) since it concerns another library.

Related Issues

fixes #10694

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

@derohimat derohimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working with this fix

@otopba
Copy link

otopba commented Apr 12, 2023

It would be great to see this PR in release

Copy link

@emmaweberyd emmaweberyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 🪄

@Lyokone Lyokone merged commit cc6d1c2 into master Apr 12, 2023
@Lyokone Lyokone deleted the fix/10694 branch April 12, 2023 12:56
@Lyokone Lyokone mentioned this pull request Apr 13, 2023
10 tasks
@firebase firebase locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_app_check] Semantic Issue (Xcode): 'new' is unavailable after upgrading xcode
6 participants