Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_analytics): allow logEvent to accept items inside parameters #13427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikitadol
Copy link

Description

Before this PR: logEvent did not accept items inside parameters
After this PR: logEvent can accept items inside parameters

Reason for this PR: On my project, our backend can send all data for analytics event, including items - this PR extends checks in _assertParameterTypesAreCorrect to allow this behavior

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@nikitadol nikitadol changed the title fix: allow logEvent to accept items inside parameters fix(firebase_analytics): allow logEvent to accept items inside parameters Oct 13, 2024
@nikitadol
Copy link
Author

@Lyokone, I saw that you can merge MR's - can you please help with this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant