Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update contributing file #2963

Merged
merged 5 commits into from
Oct 1, 2020
Merged

chore: update contributing file #2963

merged 5 commits into from
Oct 1, 2020

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Jul 15, 2020

No description provided.

@Salakar Salakar added the type: documentation Improvements or additions to documentation label Jul 15, 2020
Salakar
Salakar reviewed Jul 15, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@KristianBalaj KristianBalaj mentioned this pull request Aug 31, 2020
Open
3 tasks
Salakar
Salakar reviewed Sep 1, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
Salakar
Salakar reviewed Sep 1, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Salakar Salakar marked this pull request as ready for review October 1, 2020 13:16
@dackers86
Copy link
Member

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 1, 2020
@Ehesp Ehesp merged commit 7b82c07 into master Oct 1, 2020
@Ehesp Ehesp deleted the @ehesp/update-contributing branch October 1, 2020 15:12
@firebase firebase locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@russellwheatley russellwheatley russellwheatley left review comments

@Salakar Salakar Salakar left review comments

@kroikie kroikie kroikie left review comments

Assignees

@Ehesp Ehesp

Labels
cla: yes type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ehesp @googlebot @dackers86 @kroikie @Salakar @russellwheatley