-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(firebase_admob): integrate Admob with new core #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is it worth adding in #3236 as part of this too? |
|
Seems urgent enough to add in. |
|
Re: #3236 I don't think there's anything we need to do on the FlutterFire side other than make sure we're using the latest sdk, source: invertase/react-native-firebase#4107 |
|
Makes sense, we will have to update this dependency outside of setting Firebase Core since Firebase/AdMob is no longer updated and Firebase docs recommends direct dependency. |
Issue with flutter dev branch at the moment causing CI failures for macOS.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Deploy preview for 487e748: https://flutter-firebase-docs--pr3347-admob-new-core-tqm9oaqc.web.app (expires Wed, 02 Sep 2020 19:05:51 GMT) firebase-hosting-preview-action |
Why Firebase/AdMob is no longer updated?!!! |
|
@john990 Firebase/AdMob podspec is just a shell to bring in the underlying google ads pods, what's being said here is that we'd in future rely on the google ads pods directly instead. Only the shell podspec is what's not being updated |
|
When is the release planned for this PR? @Salakar |
|
I think this update is still in prerelease. When is it going to be published? |
Wow, this is really good news, is it implemented entirely in Flutter? Is there an approximate release date? look forward to! |

Depend on firebase_core v 0.5.0 and migrate plugin to use firebase_core native SDK versioning features;
Firebase iOS SDK versions are now locked to use the same version defined in firebase_core.
Firebase Android SDK versions are now using the Firebase Bill of Materials (BoM) to specify individual SDK versions. BoM version is also sourced from firebase_core.
Fixes #3209