Skip to content

Conversation

@kroikie
Copy link
Collaborator

@kroikie kroikie commented Aug 25, 2020

Depend on firebase_core v 0.5.0 and migrate plugin to use firebase_core native SDK versioning features;

Firebase iOS SDK versions are now locked to use the same version defined in firebase_core.
Firebase Android SDK versions are now using the Firebase Bill of Materials (BoM) to specify individual SDK versions. BoM version is also sourced from firebase_core.

Fixes #3209

@kroikie kroikie requested review from Salakar and removed request for amirh August 25, 2020 15:46
@Ehesp
Copy link
Member

Ehesp commented Aug 25, 2020

Is it worth adding in #3236 as part of this too?

@kroikie
Copy link
Collaborator Author

kroikie commented Aug 25, 2020

Seems urgent enough to add in.

@Salakar
Copy link
Member

Salakar commented Aug 25, 2020

Re: #3236 I don't think there's anything we need to do on the FlutterFire side other than make sure we're using the latest sdk, source: invertase/react-native-firebase#4107

@kroikie
Copy link
Collaborator Author

kroikie commented Aug 25, 2020

Makes sense, we will have to update this dependency outside of setting Firebase Core since Firebase/AdMob is no longer updated and Firebase docs recommends direct dependency.

@kroikie kroikie changed the title Admob new core [firebase_admob] Admob new core Aug 25, 2020
@Ehesp Ehesp changed the title [firebase_admob] Admob new core feat(firebase_admob): integrate Admob with new core Aug 26, 2020
Issue with flutter dev branch at the moment causing CI failures for macOS.
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Salakar
Copy link
Member

Salakar commented Aug 26, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@github-actions
Copy link

github-actions bot commented Aug 26, 2020

Deploy preview for 487e748:

https://flutter-firebase-docs--pr3347-admob-new-core-tqm9oaqc.web.app

(expires Wed, 02 Sep 2020 19:05:51 GMT)

firebase-hosting-preview-action

@kroikie kroikie requested a review from Ehesp as a code owner August 26, 2020 19:02
@Salakar
Copy link
Member

Salakar commented Aug 26, 2020

Both Android & iOS should be working now, have ran both locally:

image

@Salakar Salakar merged commit 26f42fc into master Aug 26, 2020
@Salakar Salakar deleted the admob-new-core branch August 26, 2020 19:27
@john990
Copy link

john990 commented Aug 27, 2020

Makes sense, we will have to update this dependency outside of setting Firebase Core since Firebase/AdMob is no longer updated and Firebase docs recommends direct dependency.

Why Firebase/AdMob is no longer updated?!!!
Developing flutter applications can’t make money. Why do we use flutter?

@Salakar
Copy link
Member

Salakar commented Aug 27, 2020

@john990 Firebase/AdMob podspec is just a shell to bring in the underlying google ads pods, what's being said here is that we'd in future rely on the google ads pods directly instead. Only the shell podspec is what's not being updated

@ghost
Copy link

ghost commented Aug 27, 2020

When is the release planned for this PR? @Salakar

@ianpark
Copy link

ianpark commented Sep 6, 2020

I think this update is still in prerelease. When is it going to be published?

https://pub.dev/packages/firebase_admob

@john990
Copy link

john990 commented Sep 8, 2020

@john990 Firebase/AdMob podspec is just a shell to bring in the underlying google ads pods, what's being said here is that we'd in future rely on the google ads pods directly instead. Only the shell podspec is what's not being updated

Wow, this is really good news, is it implemented entirely in Flutter? Is there an approximate release date? look forward to!

@firebase firebase locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_admob] version solving failed

6 participants