feat(ui): Add Hindi localization language support (#7778). #7778

adityathakurxd · 2022-01-04T16:45:42Z

Description

Added localization support for Hindi. Hindi is the main language of the Indian states of Uttar Pradesh, Haryana, Himachal Pradesh, and the capital Delhi in North India; Bihar and Jharkhand, and more.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
All existing and new tests are passing.
I updated/added relevant documentation (doc comments with ///).
The analyzer (melos run analyze) does not report any problems on my PR.
I read and followed the Flutter Style Guide.
I signed the CLA.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change.
No, this is not a breaking change.

rahulraj64

Saw some texts yet pending translations.
(I'm not from Google. Just sharing some thoughts)

rahulraj64 · 2022-01-10T09:39:36Z

packages/flutterfire_ui/lib/src/i10n/lang/hi.dart

@@ -0,0 +1,263 @@
+import '../default_localizations.dart';
+
+class EnLocalizations extends FlutterFireUILocalizationLabels {


Hello Aditya, shouldn't it be HiLocalizations?

Yes Sorry about that I'll fix this.

rahulraj64 · 2022-01-10T09:47:00Z

packages/flutterfire_ui/lib/src/i10n/lang/hi.dart

+  final String referenceLabel;
+
+  const EnLocalizations({
+    this.emailInputLabel = 'Email',


Seems there are a lot of texts yet to be translated to Hindi :) If this is a work in progress, please consider marking this as a draft :)

I had a question regarding that. I could see some other translations use Email as Email. I thought it'd do for Hindi as well. Should I like translate these too?

I suggest adding native translations where ever possible. Also, I noticed that you have used English scripts all over the place for translation. Some languages like Bahasa, Spanish, etc use English script by default and this is not the case for Hindi. For example,
Phone number zaroori hai - Wrong
फ़ोन नंबर आवश्यक है - Correct

Please note that I'm not a native Hindi speaker, these are some generic comments and I may not be able to review the translation itself

Yes, would look into that. And, update this.

Hey @rahulraj64, I have made the changes. Could you please review it again? Thanks!

rahulraj64 · 2022-01-10T15:26:47Z

packages/flutterfire_ui/lib/src/i10n/lang/hi.dart

+    this.signOutButtonText = 'Sign out',
+    this.phoneInputLabel = 'Phone number',
+    this.phoneNumberInvalidErrorText = 'Phone number is invalid',
+    this.phoneNumberIsRequiredErrorText = 'Phone number zaroori hai',


Use proper language script all over your translations. Currently, they are Hindi-In-English (Not proper Hindi translations)

lesnitsky · 2022-01-13T14:22:06Z

packages/flutterfire_ui/lib/src/i10n/default_localizations.dart

@@ -1,3 +1,4 @@
+import 'package:flutterfire_ui/src/i10n/lang/hi.dart';


Suggested change

import 'package:flutterfire_ui/src/i10n/lang/hi.dart';

import 'lang/hi.dart';

lesnitsky · 2022-01-13T14:22:29Z

packages/flutterfire_ui/lib/src/i10n/lang/hi.dart

@@ -0,0 +1,263 @@
+import '../default_localizations.dart';
+
+class EnLocalizations extends FlutterFireUILocalizationLabels {


Suggested change

class EnLocalizations extends FlutterFireUILocalizationLabels {

class HiLocalizations extends FlutterFireUILocalizationLabels {

lesnitsky

Still several unresolved review comments.
@adityathakurxd would you be able to make relevant changes?

adityathakurxd · 2022-01-13T14:27:44Z

Yes, @lesnitsky I'll update with the required changes. Sorry for the delay.

lesnitsky · 2022-01-13T15:11:27Z

packages/flutterfire_ui/lib/src/i10n/lang/hi.dart

+    this.signInWithEmailLinkSentText =
+        "हमने आपको एक जादुई लिंक के साथ एक ईमेल भेजा है। अपना ईमेल जांचें और साइन इन करने के लिए लिंक का अनुसरण करें",
+    this.sendLinkButtonLabel = 'मैजिक लिंक भेजें',
+    this.arrayLabel = 'array',


@adityathakurxd could these (lines 243 to 261) labels be translated as well?

I have updated the same.

adityathakurxd · 2022-01-15T08:05:59Z

Hi, @lesnitsky Could you tell me about the checks? How can I improve for them?

russellwheatley · 2022-02-15T12:10:41Z

Hey @adityathakurxd, thanks for the PR! Do you mind resolving the merge conflict, please?

Hey @rahulraj64, do you mind proofreading the update language translations in Hindi and approving if you find acceptable, please? Unfortunately, none of the maintainers I know speak Hindi. Thank you!

adityathakurxd · 2022-02-15T12:14:12Z

Hey @russellwheatley, I have resolved the merge conflicts.

russellwheatley · 2022-02-22T11:38:19Z

Hey @adityathakurxd, I don't think the merge conflict has been resolved.

adityathakurxd · 2022-02-23T05:39:08Z

Hey @russellwheatley, Sorry about that. I had last resolved the conflicts 8 days ago and #7709 was merged just after that which caused it again. Thank you! Let me know if there's anything else I need to do.

russellwheatley · 2022-02-23T11:22:24Z

Hey @adityathakurxd, do you mind getting a fellow developer who speaks Hindi to proofread & approve to ensure there are no mistakes (We all make them 😄 ), please?

adityathakurxd · 2022-02-23T11:35:18Z

Sure @russellwheatley I'll ask a few developers to review this.

infiniteoverflow · 2022-02-23T13:10:11Z

All the translations are perfect.

@adityathakurxd just curious about the following :

verifyPhoneNumberButtonText and linkEmailButtonText are both translated to अगला. Does this have to be like this in this context or can it be changed to फ़ोन नंबर सत्यापित करें and लिंक ईमेल ?

adityathakurxd · 2022-02-23T13:16:52Z

Hey, Aswin (@infiniteoverflow)
Thank you so much for the review! I had translated the original en.dart available here. Both the verifyPhoneNumberButtonText and linkEmailButtonText are button labels that say 'Next' in English so I thought it'd best to translate them to अगला just in case there are further steps to be performed.

russellwheatley

LGTM

feat(ui): add Hindi localization support

aa452bd

rahulraj64 reviewed Jan 10, 2022

View reviewed changes

lesnitsky reviewed Jan 13, 2022

View reviewed changes

lesnitsky requested changes Jan 13, 2022

View reviewed changes

adityathakurxd and others added 2 commits January 13, 2022 20:36

Added localizations and did requested changes

7ca0f6f

Merge branch 'master' into master

c3a76c2

adityathakurxd requested a review from lesnitsky January 13, 2022 15:08

lesnitsky reviewed Jan 13, 2022

View reviewed changes

Remaining translations

06d39dc

adityathakurxd requested a review from lesnitsky January 13, 2022 15:56

merge master

a3f7038

lesnitsky approved these changes Jan 31, 2022

View reviewed changes

trigger ci

a0c673c

Merge branch 'master' into master

0476bab

russellwheatley added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Feb 22, 2022

Merge branch 'master' into master

e8bc88c

google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Feb 23, 2022

adityathakurxd requested a review from lesnitsky February 23, 2022 05:39

Merge branch 'master' into master

7780463

russellwheatley approved these changes Feb 24, 2022

View reviewed changes

russellwheatley changed the title ~~feat(ui): add Hindi localization support~~ feat(ui): Add Hindi localization language support (#7778). Feb 24, 2022

russellwheatley merged commit b584ce0 into firebase:master Feb 24, 2022

firebase locked and limited conversation to collaborators Mar 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): Add Hindi localization language support (#7778). #7778

feat(ui): Add Hindi localization language support (#7778). #7778

adityathakurxd commented Jan 4, 2022

rahulraj64 left a comment •

edited

Loading

rahulraj64 Jan 10, 2022

adityathakurxd Jan 10, 2022

rahulraj64 Jan 10, 2022 •

edited

Loading

adityathakurxd Jan 10, 2022

rahulraj64 Jan 10, 2022

adityathakurxd Jan 13, 2022

adityathakurxd Jan 13, 2022

rahulraj64 Jan 10, 2022

lesnitsky Jan 13, 2022

lesnitsky Jan 13, 2022 •

edited

Loading

lesnitsky left a comment

adityathakurxd commented Jan 13, 2022

lesnitsky Jan 13, 2022

adityathakurxd Jan 13, 2022

adityathakurxd commented Jan 15, 2022

russellwheatley commented Feb 15, 2022

adityathakurxd commented Feb 15, 2022

russellwheatley commented Feb 22, 2022

adityathakurxd commented Feb 23, 2022

russellwheatley commented Feb 23, 2022

adityathakurxd commented Feb 23, 2022

infiniteoverflow commented Feb 23, 2022

adityathakurxd commented Feb 23, 2022

russellwheatley left a comment

		@@ -0,0 +1,263 @@
		import '../default_localizations.dart';

		class EnLocalizations extends FlutterFireUILocalizationLabels {

		@@ -1,3 +1,4 @@
		import 'package:flutterfire_ui/src/i10n/lang/hi.dart';

	import 'package:flutterfire_ui/src/i10n/lang/hi.dart';
	import 'lang/hi.dart';

	class EnLocalizations extends FlutterFireUILocalizationLabels {
	class HiLocalizations extends FlutterFireUILocalizationLabels {

feat(ui): Add Hindi localization language support (#7778). #7778

feat(ui): Add Hindi localization language support (#7778). #7778

Conversation

adityathakurxd commented Jan 4, 2022

Description

Checklist

Breaking Change

rahulraj64 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahulraj64 Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesnitsky Jan 13, 2022 • edited Loading

Choose a reason for hiding this comment

lesnitsky left a comment

Choose a reason for hiding this comment

adityathakurxd commented Jan 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adityathakurxd commented Jan 15, 2022

russellwheatley commented Feb 15, 2022

adityathakurxd commented Feb 15, 2022

russellwheatley commented Feb 22, 2022

adityathakurxd commented Feb 23, 2022

russellwheatley commented Feb 23, 2022

adityathakurxd commented Feb 23, 2022

infiniteoverflow commented Feb 23, 2022

adityathakurxd commented Feb 23, 2022

russellwheatley left a comment

Choose a reason for hiding this comment

rahulraj64 left a comment •

edited

Loading

rahulraj64 Jan 10, 2022 •

edited

Loading

lesnitsky Jan 13, 2022 •

edited

Loading