fix(auth): Pass the clientId into GoogleSignIn #9823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I started noticing flutter/flutter#114304 when migrating to
firebase_ui
fromflutterfire_ui
, and tried to fix it, since I really need to ship an update that depends on not including all the providers. I found that theclientId
is not passed intoGoogleSignIn
, so I tried adding it, which works. I also checked the previous provider implementation fromflutterfire_ui
which added it too, so I assume this is a mistake thatfirebase_ui
doesn't ATM.Note that I use Dart-only initialization, it may not surface when the Google plist is included in the iOS app.
By the way, the issue prevents users from logging out regardless of the authentication method they used to log in.
Regarding the checklist: I couldn't manage to run the e2e tests with Melos, I had a ton of Xcode compilation errors, so I gave up on that, the changes are fairly small, and the unit tests passed, so I hope this PR is a good starter to have this issue fixed as it is. Also, I'm not sure how to add tests for these changes, if you want them, please advise.
Thank you.
Related Issues
Flutterfire repo
Main flutter repo
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?