1st gen imports and codebases #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Jul 6, 2023
jhuleatt
commented
Jul 7, 2023
Comment on lines
19
to
+21
| // [START import] | ||
| // The Cloud Functions for Firebase SDK to create Cloud Functions and set up triggers. | ||
| const functions = require("firebase-functions"); | ||
| const functions = require('firebase-functions/v1'); |
There was a problem hiding this comment.
FYI @egilmorez this change touches the 1st gen "get started" snippet: https://firebase.google.com/docs/functions/get-started?gen=1st#import-the-required-modules-and-initialize-an-app_1
There was a problem hiding this comment.
Yup! As long as the tag names dont' change, I'll just need to republish to catch this and any other updates to snippets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firebase-functions/v1import in 1st gen samples to make it more explicit that it is 1st gen code