Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifting definePrompt to genkit core #11

Merged
merged 1 commit into from
May 3, 2024
Merged

Lifting definePrompt to genkit core #11

merged 1 commit into from
May 3, 2024

Conversation

maxl0rd
Copy link
Contributor

@maxl0rd maxl0rd commented May 2, 2024

This PR lifts prompts into a core Genkit action and facilitates paths to supporting alternative prompting approaches and/or templating systems. It also tweaks Dotprompt somewhat to interact with the new structure.

  • Moving definePrompt into ai package
  • Reimagining dotprompt to follow the new contract
  • Adding renderPrompt veneer to facilitate using prompts in code
  • Updating tests and samples to use defineDotprompt.
  • Adding new docs for prompts and updating dotprompt

@maxl0rd maxl0rd requested review from mbleigh and pavelgj May 2, 2024 16:15
Copy link
Collaborator

@pavelgj pavelgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall -- I like this a lot!

js/dotprompt/src/dotprompt.ts Outdated Show resolved Hide resolved
js/dotprompt/README.md Outdated Show resolved Hide resolved
- Moving definePrompt into ai package
- Reimagining dotprompt to follow the new contract
- Adding renderPrompt veneer to facilitate using prompts in code
- Updating tests and samples to use defineDotprompt.
- Adding new docs for prompts and updating dotprompt
@maxl0rd maxl0rd merged commit 6a66966 into main May 3, 2024
4 checks passed
@maxl0rd maxl0rd deleted the prompts branch May 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants