Skip to content

Update I/O metrics to be counters instead of histograms #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024
Merged

Update I/O metrics to be counters instead of histograms #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions js/ai/src/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,50 +52,50 @@ const generateActionLatencies = new MetricHistogram(_N('generate/latency'), {
unit: 'ms',
});

const generateActionInputCharacters = new MetricHistogram(
_N('generate/input_characters'),
const generateActionInputCharacters = new MetricCounter(
_N('generate/input/characters'),
{
description: 'Histogram of input characters to a Genkit model.',
description: 'Counts input characters to any Genkit model.',
valueType: ValueType.INT,
}
);

const generateActionInputTokens = new MetricHistogram(
_N('generate/input_tokens'),
const generateActionInputTokens = new MetricCounter(
_N('generate/input/tokens'),
{
description: 'Histogram of input tokens to a Genkit model.',
description: 'Counts input tokens to a Genkit model.',
valueType: ValueType.INT,
}
);

const generateActionInputImages = new MetricHistogram(
_N('generate/input_images'),
const generateActionInputImages = new MetricCounter(
_N('generate/input/images'),
{
description: 'Histogram of input images to a Genkit model.',
description: 'Counts input images to a Genkit model.',
valueType: ValueType.INT,
}
);

const generateActionOutputCharacters = new MetricHistogram(
_N('generate/output_characters'),
const generateActionOutputCharacters = new MetricCounter(
_N('generate/output/characters'),
{
description: 'Histogram of output characters to a Genkit model.',
description: 'Counts output characters from a Genkit model.',
valueType: ValueType.INT,
}
);

const generateActionOutputTokens = new MetricHistogram(
_N('generate/output_tokens'),
const generateActionOutputTokens = new MetricCounter(
_N('generate/output/tokens'),
{
description: 'Histogram of output tokens to a Genkit model.',
description: 'Counts output tokens from a Genkit model.',
valueType: ValueType.INT,
}
);

const generateActionOutputImages = new MetricHistogram(
_N('generate/output_images'),
const generateActionOutputImages = new MetricCounter(
_N('generate/output/images'),
{
description: 'Histogram of output images to a Genkit model.',
description: 'Count output images from a Genkit model.',
valueType: ValueType.INT,
}
);
Expand Down Expand Up @@ -319,12 +319,12 @@ function doRecordGenerateActionMetrics(
generateActionLatencies.record(dimensions.latencyMs, shared);

// inputs
generateActionInputTokens.record(dimensions.inputTokens, shared);
generateActionInputCharacters.record(dimensions.inputCharacters, shared);
generateActionInputImages.record(dimensions.inputImages, shared);
generateActionInputTokens.add(dimensions.inputTokens, shared);
generateActionInputCharacters.add(dimensions.inputCharacters, shared);
generateActionInputImages.add(dimensions.inputImages, shared);

// outputs
generateActionOutputTokens.record(dimensions.outputTokens, shared);
generateActionOutputCharacters.record(dimensions.outputCharacters, shared);
generateActionOutputImages.record(dimensions.outputImages, shared);
generateActionOutputTokens.add(dimensions.outputTokens, shared);
generateActionOutputCharacters.add(dimensions.outputCharacters, shared);
generateActionOutputImages.add(dimensions.outputImages, shared);
}