Skip to content

Added -o, --open flag to launch the browser to genkit start #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2024
+8 −3
Merged

Added -o, --open flag to launch the browser to genkit start #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe3d603
Added `-o, --open` flag to launch the browser to `genkit start`
pavelgj May 10, 2024
e7f8af9
format
pavelgj May 10, 2024
8284707
simplify
pavelgj May 10, 2024
66758ac
cleanup
pavelgj May 10, 2024
06cdd62
more cleanup
pavelgj May 10, 2024
7070da2
Developer UI
pavelgj May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion genkit-tools/cli/src/commands/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ interface StartOptions {
headless?: boolean;
port: string;
attach?: string;
open?: boolean;
}

/** Command to start GenKit server, optionally without static file serving */
Expand All @@ -35,6 +36,7 @@ export const start = new Command('start')
false
)
.option('-p, --port <number>', 'Port to serve on. Default is 4000', '4000')
.option('-o, --open', 'Open the browser with the Developer UI')
.option(
'-a, --attach <number>',
'Externally running dev process address to attach to'
Expand All @@ -57,5 +59,5 @@ export const start = new Command('start')
} else {
await runner.start();
}
return startServer(runner, options.headless ?? false, port);
return startServer(runner, options.headless ?? false, port, !!options.open);
});
7 changes: 5 additions & 2 deletions genkit-tools/common/src/server/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ const API_BASE_PATH = '/api';
export function startServer(
runner: Runner,
headless: boolean,
port: number
port: number,
openBrowser: boolean
): Promise<void> {
let serverEnder: (() => void) | undefined = undefined;
const enderPromise = new Promise<void>((resolver) => {
Expand Down Expand Up @@ -133,7 +134,9 @@ export function startServer(
.waitUntilHealthy()
.then(() => {
logger.info(`${clc.green(clc.bold('Genkit Tools UI:'))} ${uiUrl}`);
open(uiUrl);
if (openBrowser) {
open(uiUrl);
}
})
.catch((e) => {
logger.error(e.message);
Expand Down