Moved menu and coffee shop samples into top level samples folder #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDoyle
approved these changes
May 13, 2024
pavelgj
changed the title
i2amsam
reviewed
May 13, 2024
samples/js-coffee-shop/package.json
Outdated
There was a problem hiding this comment.
This makes sense to me, thinking through the process, if someone is just testing they can genkit start here and build and run using the published versions. If they're doing local development the best process would be to bump their local package.json file to the next patch/RC version and the validate that it's getting picked up in these samples, but they shouldn't have to adjust the imports since they're getting ~'d in, is that right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and made them depend on npm versions of genkit packages and easily runnable with npm (pnpm not required)